#9403 closed Bug (duplicate)
_set_content needs to perform the same _is_string check as the Constructor
| Reported by: | magneto | Owned by: | nobody |
|---|---|---|---|
| Component: | HTTP handling | Version: | master |
| Severity: | Normal | Keywords: | |
| Cc: | yozh | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the HttpResponse constructor one checks that the input content is a string or an iterator itself.
shouldn't _set_content do the same as well?
Attachments (1)
Change History (14)
Changed 8 years ago by
| Attachment: | httpResp_set_content.diff added |
|---|
comment:1 Changed 8 years ago by
| milestone: | post-1.0 |
|---|
comment:2 Changed 8 years ago by
| Needs documentation: | unset |
|---|---|
| Needs tests: | unset |
| Patch needs improvement: | unset |
| Triage Stage: | Unreviewed → Design decision needed |
Can you explain why this would be needed? Is there an error you've found?
comment:3 Changed 8 years ago by
| Triage Stage: | Design decision needed → Accepted |
|---|
I think I understand this one (from memory, it looked pretty obvious the first time I saw it). Is we allow passing an interator to the constructor, then it's consistent to allow also setting the content using the same iterator: it's the same process, just slightly delayed. Right now, that won't work.
Move to "accepted", but if you've got some broader problem, Jacob, feel free to override me. Iterators and HttpResponse are pretty funky right now anyway.
comment:4 Changed 7 years ago by
| Component: | Uncategorized → HTTP handling |
|---|
comment:5 Changed 7 years ago by
| Cc: | yozh added |
|---|
comment:6 Changed 6 years ago by
Could you please resolve the issue? I need to call wsgi handler from django.
comment:7 Changed 5 years ago by
| Needs tests: | set |
|---|---|
| Severity: | → Normal |
| Type: | → Uncategorized |
comment:8 Changed 5 years ago by
| Type: | Uncategorized → Bug |
|---|
comment:12 Changed 4 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
Agreed, this has been fixed in that other ticket.
Milestone post-1.0 deleted