Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#9402 closed (duplicate)

Whitespace validates in any field that is required

Reported by: Henk de Vries Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: whitespace fields
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


How to reproduce:
Create a form with a CharField that has required=True .

Put whitespace into the field ( for example 4 spaces ).

Submit the form. It will validate as is_valid().

The problem lies in at line 111 ( django trunk ):

    def clean(self, value):
        Validates the given value and returns its "cleaned" value as an
        appropriate Python object.

        Raises ValidationError for any errors.
        if self.required and value in EMPTY_VALUES:
            raise ValidationError(self.error_messages['required'])
        return value

At line 46 is the following:

# These values, if given to to_python(), will trigger the self.required check.
EMPTY_VALUES = (None, '')

Problem is that any amount of whitespace will get through this check. I don't know how you guys think about this ( I mean, whitespace is data ;-) ), but filling in whitespace has pretty much the same effect as filling in nothing.

Proposed fix:

        if self.required and value.rstrip() in EMPTY_VALUES:

I know I should do this with a patch etc. but I don't know how to do this. I hope this is sufficient.

Thanks in advance,


Change History (3)

comment:1 Changed 10 years ago by Henk de Vries

if value is None .rstrip() will raise an Error. I'm not an experienced Python programmer, so my bad for that ;-).

comment:2 Changed 10 years ago by Brian Rosner

Resolution: duplicate
Status: newclosed

Duplicate of #6362.

comment:3 Changed 10 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top