Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9276 closed (fixed)

class="inline-related " for stacked inline editables in admin has trailing space

Reported by: creecode@… Owned by: nobody
Component: contrib.admin Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I needed to view the source for an admin webpage with a stacked inline editable in it and noticed that the css class name "inline-related " has a trailing space.

The problem seems to be here < http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/templates/admin/edit_inline/stacked.html#L8 >.

Attachments (1)

stacked_html.diff (982 bytes) - added by creecode 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Stupidly trivial, but hey - it's obviously a trivial fix. Want to provide a patch to make it even more trivial to fix? Thanks

Changed 6 years ago by creecode

comment:2 Changed 6 years ago by creecode

  • Has patch set

Very trivial but on the upside I get a chance to submit a patch for Django, something I haven't done before. :-) Hopefully I've done it correctly.

comment:3 Changed 6 years ago by SmileyChris

  • Triage Stage changed from Accepted to Ready for checkin

Perfect! (getting you to do it that was sort of the aim)

Now go patch some more meaty tickets ;)

comment:4 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [9877]) Fixed #9276 -- Corrected the way the CSS class is rolled out in a stacked edit-inline template. Thanks to creecode@… for the report and fix.

comment:5 Changed 6 years ago by russellm

(In [9878]) [1.0.X] Fixed #9276 -- Corrected the way the CSS class is rolled out in a stacked edit-inline template. Thanks to creecode@… for the report and fix.

Merge of r9877 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top