Code

Opened 6 years ago

Closed 6 years ago

#9235 closed (fixed)

Getting doc page at URL without trailing slash breaks all links

Reported by: joaoolavo Owned by: nobody
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Attachments (0)

Change History (5)

comment:1 Changed 6 years ago by kmtracey

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

Actually, none of the links (Writing models, Model field reference, Related objects reference, etc.) work with the url given. The problem with http://docs.djangoproject.com/en/dev/ref/models is that it is missing a trailing slash. If you use http://docs.djangoproject.com/en/dev/ref/models/ instead all the links on the page work. So, is there somewhere in the docs that you followed a link to this page and got the url without the trailing slash or did you enter in the browser directly? If the former, we need to fix where the link is specified, if the latter I'm not sure what can be done about it.

comment:2 Changed 6 years ago by carljm

  • Component changed from Uncategorized to Documentation
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Summary changed from Broke link in "Model field reference" to Getting doc page at URL without trailing slash breaks all links

In the latter case it seems like it should be possible (and not too difficult) to either redirect with appended slash or just make the URL a 404 if it doesn't have the trailing slash. Either one seems preferable to being able to load doc pages with every link on the page broken (I can foresee that being a source of many spurious bug reports on down the line).

Given that, reopening with adjusted Summary.

comment:3 Changed 6 years ago by kmtracey

Agreed. I've just noticed that some of the doc search links come back without trailing slashes (for example, search for Admin in the docs and the first link (to tutorial part 2) has no trailing slash, so if you follow it links from that page don't work). Seems redirecting with an appended slash would be best, but the webserver config for djangoproject is outside my ken so someone else hopefully knows how to fix it up.

comment:4 Changed 6 years ago by carljm

Not sure why it wasn't marked as such in the commit log, but I believe this was just fixed by r9097.

comment:5 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.