#9213 closed (fixed)
PasswordResetForm should not reset passwords for inactive users
| Reported by: | John-Scott Atlakson | Owned by: | anonymous |
|---|---|---|---|
| Component: | contrib.auth | Version: | 1.3-alpha |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
django.contrib.auth.forms.PasswordResetForm currently just validates that there is at least one User object with the form submitted email address. However, users that have been set is_active = False can still send out password reset emails to themselves, which in my email template, displays their first name. I'd rather not give the impression that I'm hanging onto their personal data, just following the Django pattern of setting the is_active flag so banned users can't sign up with the same email again. I've attached a trivial patch. Although I've stated the short summary in the affirmative, if there are good reasons not to do this check, I'm all ears.
Attachments (2)
Change History (11)
by , 16 years ago
| Attachment: | auth_forms.diff added |
|---|
comment:1 by , 16 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 14 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Version: | 1.0 → 1.3-alpha |
comment:3 by , 14 years ago
| milestone: | → 1.3 |
|---|
comment:4 by , 14 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
comment:5 by , 14 years ago
| Component: | Contrib apps → Authentication |
|---|
by , 14 years ago
| Attachment: | 9213.patch2 added |
|---|
comment:6 by , 14 years ago
in 9213.patch2 there is a one liner change in ResetPasswordForm.clean_email()
a new test fails before and works after.
added test case, refactored other tests in the same suite a bit.