PasswordResetForm should not reset passwords for inactive users
django.contrib.auth.forms.PasswordResetForm currently just validates that there is at least one User object with the form submitted email address. However, users that have been set is_active = False can still send out password reset emails to themselves, which in my email template, displays their first name. I'd rather not give the impression that I'm hanging onto their personal data, just following the Django pattern of setting the is_active flag so banned users can't sign up with the same email again. I've attached a trivial patch. Although I've stated the short summary in the affirmative, if there are good reasons not to do this check, I'm all ears.
| Triage Stage: |
Unreviewed → Accepted
|
| Owner: |
changed from nobody to anonymous
|
| Status: |
new → assigned
|
| Version: |
1.0 → 1.3-alpha
|
| Needs documentation: |
set
|
| Needs tests: |
set
|
| Component: |
Contrib apps → Authentication
|
| Resolution: |
→ fixed
|
| Status: |
assigned → closed
|
added test case, refactored other tests in the same suite a bit.