Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9027 closed (fixed)

modelformset_factory docs say "by default uses can_delete=True" but it doesn't

Reported by: gsf Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The docs on modelformset_factory say it uses can_delete=True by default (see first note at http://docs.djangoproject.com/en/dev/topics/forms/modelforms/#id1), but it functions as can_delete=False. Patch included.

Attachments (1)

mf_f-can-delete.diff (626 bytes) - added by gsf 6 years ago.
modelformset_factory can_delete patch

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by gsf

modelformset_factory can_delete patch

comment:1 Changed 6 years ago by brosner

  • Component changed from Forms to Documentation
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

As I noted on #9058 this is a documentation not a code problem. That makes the patch wrong. I will be fixing the documentation shortly.

comment:2 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [9016]) Fixed #9027 -- Corrected the documentation about can_delete default value. Thanks gsf for catching this.

comment:3 Changed 6 years ago by gsf

Great, though I don't agree with the documentation fix. See #9060.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.