Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#9027 closed (fixed)

modelformset_factory docs say "by default uses can_delete=True" but it doesn't

Reported by: Gabriel Farrell Owned by: nobody
Component: Documentation Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The docs on modelformset_factory say it uses can_delete=True by default (see first note at ​http://docs.djangoproject.com/en/dev/topics/forms/modelforms/#id1), but it functions as can_delete=False. Patch included.

Attachments (1)

mf_f-can-delete.diff​ (626 bytes ) - added by Gabriel Farrell 16 years ago.
modelformset_factory can_delete patch

Download all attachments as: .zip

Change History (4)

by Gabriel Farrell, 16 years ago

Attachment: mf_f-can-delete.diff​ added

modelformset_factory can_delete patch

comment:1 by Brian Rosner, 16 years ago

Component: Forms → Documentation
Triage Stage: Unreviewed → Accepted

As I noted on #9058 this is a documentation not a code problem. That makes the patch wrong. I will be fixing the documentation shortly.

comment:2 by Brian Rosner, 16 years ago

Resolution: → fixed
Status: new → closed

(In [9016]) Fixed #9027 -- Corrected the documentation about can_delete default value. Thanks gsf for catching this.

comment:3 by Gabriel Farrell, 16 years ago

Great, though I don't agree with the documentation fix. See #9060.

Note: See TracTickets for help on using tickets.
Back to Top