url templatetag incorrectly assumes settings.SETTINGS_MODULE is not set to None
|Reported by:||Matt McDonald||Owned by:||nobody|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
When rolling your own config using conf.settings.configure() instead of the DJANGO_SETTINGS_MODULE environment variable, settings.SETTINGS_MODULE gets set to None. Any code which assumes that settings.SETTINGS_MODULE has been set to a string would be incorrect.
I've attached a patch to fix an occurrence of this issue in the url templatetag which currently causes an
AttributeError: 'NoneType' object has no attribute 'split'.
Change History (9)
comment:2 Changed 8 years ago by
|Patch needs improvement:||unset|
|Triage Stage:||Unreviewed → Accepted|