URLNode raises "Reverse for 'settings.view_name' ... not found."

[nishio]

URLNode raises strange exception as below

Reverse for 'settings.new_game' with arguments '(u'1',)' and keyword arguments '{}' not found.

It is because URLNode try to find "project_name.view_name" even if there is no project name. This error message makes users confused. It should fail fast.

I attached a patch.

Index: django/template/defaulttags.py
===================================================================
--- django/template/defaulttags.py      (revision 10138)
+++ django/template/defaulttags.py      (working copy)
@@ -371,6 +371,7 @@
         try:
             url = reverse(self.view_name, args=args, kwargs=kwargs)
         except NoReverseMatch:
+            if "." not in settings.SETTINGS_MODULE: raise
             project_name = settings.SETTINGS_MODULE.split('.')[0]
             try:
                 url = reverse(project_name + '.' + self.view_name,

[nishio]

patch

[Malcolm Tredinnick]

This is a known problem (I'm be surprised if this wasn't a dupe of some other ticket, but I can't find it at the moment), however the proposed fix isn't correct. The presence or otherwise of a period in the settings module's import path isn't indicative of anything about the project directory. We should basically not report anything from that last block if it raises an exception, since it's really just a safety net for beginners.

We do need a better error reporting there, but this isn't the way to do it.

[nishio]

I agree that the proposal is not correct solution, but I think it is better than now. The following code is also incorrect. It assumes SETTINGS_MODULE is "project_name.settings" style. That's why the error message strange.

project_name = settings.SETTINGS_MODULE.split('.')[0]

This fix is not the better error reporting but a better one.

[nishio]

Sorry, I made 2 mistake in above comment.

I agree that the proposal is not perfect solution, but I think it is better than now. The following code is also incorrect. It assumes SETTINGS_MODULE is "project_name.settings" style. That's why the error message strange.

project_name = settings.SETTINGS_MODULE.split('.')[0]

This fix is not the best error reporting but a better one.

[Jacob]

(In [10351]) [1.0.X] Fixed #9005: don't wig out when reversing a URL if SETTINGS_MODULE isn't set. While I was there, I fixed #10599 by re-raising the original error message, which is almost always a better idea. Thanks, Eric. Backport of r10350 from trunk.