Opened 8 years ago

Closed 8 years ago

#9000 closed (fixed)

Documentation for reverse() and all() QuerySet methods missing

Reported by: Ramiro Morales Owned by: nobody
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Attachments (2)

doc-fixes-r8995.diff (26.2 KB) - added by Ramiro Morales 8 years ago.
Patch generated using Mercurial, apply using patch -p1
doc-fixes-r8995-2.diff (2.6 KB) - added by Ramiro Morales 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by Ramiro Morales

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

The patch attached contains also fixes for tickets documentation #6979, #7102, #8371, #8480, #8858, #8969, #8996 as of r8995.

I have decided to no specify -bB command line switches to hg diff so the patch also contains a bunch of trailing spaces truncation thunks in the modified files.

comment:2 Changed 8 years ago by Ramiro Morales

Has patch: set

Changed 8 years ago by Ramiro Morales

Attachment: doc-fixes-r8995.diff added

Patch generated using Mercurial, apply using patch -p1

comment:3 Changed 8 years ago by simon

Patch needs improvement: set

Your patch makes changes to a large number of files within Django. Could you resubmit the patch to just address reverse() and all()? Doing so would make it a lot easier to apply.

comment:4 Changed 8 years ago by Ramiro Morales

Simon:

It seemed a bit awkward to have to create individual patches and get a committer to analize them apiece for issues (ten in total) that are all obvious documentation bugs (typos, reST errors), some of them unreported detected by a visual inspection of all the documentation.

I've attached doc-fixes-r8995-2.diff generated by running

$ filterdiff --strip=1 -i *querysets.txt doc-fixes-r8995.diff > doc-fixes-r8995-2.diff

but please consider reviewing and applying all the other fixes included in doc-fixes-r8995.diff

Changed 8 years ago by Ramiro Morales

Attachment: doc-fixes-r8995-2.diff added

comment:5 Changed 8 years ago by simon

(In [9005]) Re-added docs for QuerySet reverse() and all() methods, refs #9000 - thanks ramiro

comment:6 Changed 8 years ago by simon

Resolution: fixed
Status: newclosed

(In [9010]) Small documentation tweaks, fixes #9000 - thanks, ramiro

Note: See TracTickets for help on using tickets.
Back to Top