Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8979 closed (fixed)

Documentation fixes

Reported by: Ramiro Morales Owned by: nobody
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

A few issues thata haven't already been reported in other Component:Documentation tickets: reST fixes, addition of Pygmentation to some files, typos.

Attachments (1)

doc-fixes-r8985.diff (12.7 KB) - added by Ramiro Morales 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Ramiro Morales

Attachment: doc-fixes-r8985.diff added

comment:1 Changed 8 years ago by Adrian Holovaty

Note that this patch did not apply cleanly for me, as it refers to "a/docs" and "b/docs". In the future, could you do a "svn diff" from within the main "trunk" directory to produce a clean patch?

comment:2 Changed 8 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [8987]) Fixed #8979 -- Made a bunch of typo/formatting fixes to the docs. Thanks, ramiro

comment:3 in reply to:  1 Changed 8 years ago by Ramiro Morales

Replying to adrian:

Note that this patch did not apply cleanly for me, as it refers to "a/docs" and "b/docs". In the future, could you do a "svn diff" from within the main "trunk" directory to produce a clean patch?

Problem is I don't use SVN, the patch was generated from work in a named branch in a Mercurial repository, I think git does also generates that kind of patches. See Jacob's comment here

comment:4 in reply to:  1 Changed 8 years ago by Marc Fargas

Replying to adrian:

Note that this patch did not apply cleanly for me, as it refers to "a/docs" and "b/docs". In the future, could you do a "svn diff" from within the main "trunk" directory to produce a clean patch?


Tip: "patch -p1 < diff-file.diff"

The "-pN" parameter means "Strip the smallest prefix containing num leading slashes...", so, in this case would mean "Strip b/ and a/". It defaults to "-p0" ;)

Git, Mercurial, even doing diff by hand (i.e. when using a release tarball) will generate diff with those prefix, then "-p1" does the job ;)

comment:5 Changed 8 years ago by Adrian Holovaty

Looks like I missed the Cool Kids' memo about Git patches. Thanks for the pointer!

Note: See TracTickets for help on using tickets.
Back to Top