#8705 closed (fixed)
Indentation problem in topics/db/models.txt
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Keywords: | rst, indentation | |
| Cc: | zerok@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The definition list of field options is rendered as blockquotes (and nested blockquotes). Fixed in attached patch.
Attachments (3)
Change History (10)
by , 16 years ago
| Attachment: | indentation_modelstxt.diff added |
|---|
comment:1 by , 16 years ago
| milestone: | → 1.0 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
follow-up: 5 comment:2 by , 16 years ago
richardb: git diff format is common enough these days that we accept it. I'll update the guidelines when I get a chance.
comment:3 by , 16 years ago
Note to reviewers: The OP is describing the rendering in a local copy generated by make html as can be seen in the attached snapshot (Firefox 3, but it also happens with Safari 3.1.2, Konqueror 3.5 and IE7)
When I submitted #8693/[8737] (that took the opposite approach) it was guided by what I was seeing in the copy at http://docs.djangoproject.com/ so it seems the style sheets are different. This would also mean the rendering at the documentation website should be checked if/when this patch is committed.
by , 16 years ago
by , 16 years ago
| Attachment: | t8705_r8767.diff added |
|---|
New version of the patch with unneeded trailing spaces removed
comment:4 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
follow-up: 6 comment:5 by , 16 years ago
Replying to jacob:
richardb: git diff format is common enough these days that we accept it. I'll update the guidelines when I get a chance.
Jacob: Ok, noted.
Horst Gutmann: apologies for criticizing your patch when it was, in fact, up to expected standards :-)
comment:6 by , 16 years ago
Replying to richardb:
Replying to jacob:
richardb: git diff format is common enough these days that we accept it. I'll update the guidelines when I get a chance.
Jacob: Ok, noted.
Horst Gutmann: apologies for criticizing your patch when it was, in fact, up to expected standards :-)
Richard: No stress :-) I actually totally missed that passage in the guidelines until today ;-)
Tried out the patch, works as intended and fixes the incorrect rendering in the documentation.
To the original submitter: in future, can you submit patches in
svn diffformat rather than using the diff output from another Version Control tool? It will then conform to the Django patch guidelines and make life a lot easier for people (like myself) who are using the standard tools :-)