#8971 closed (fixed)
URL resolution for admindocs reST roles incorrect
| Reported by: | Ben Spaulding | Owned by: | Armin Ronacher |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | admindocs urls | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The parse_rst method in admindocs/utils.py has a link_base argument set to "../.." — that works fine if the the link being created is in either the model_detail or view_detail view. But if the view is being created in the tag_index or detail_index the url does not resolve correctly.
The attached patch is a solid solution, but possibly temporary. It simply has the tag_index and model_index views pass parse_rst a link_base kwarg set to the correct relative URL. I think a better solution would be to have the roles’ URLs use reverse() rather than be hard-coded. I tried to do that, but it is difficult as reverse() needs views.py to resolve the URL and views.py relies on utils.py. I am sure it can be done, but I couldn’t figure out how.
Attachments (2)
Change History (10)
by , 16 years ago
| Attachment: | admindocs-link_base.diff added |
|---|
comment:1 by , 16 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 16 years ago
| Component: | Uncategorized → django.contrib.admin |
|---|
comment:3 by , 16 years ago
| Owner: | changed from to |
|---|
comment:4 by , 16 years ago
comment:6 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:7 by , 16 years ago
Note:
See TracTickets
for help on using tickets.
Attached a patch that drops
link_baseand reverses the url to the root properly.