URL resolution for admindocs reST roles incorrect
The parse_rst method in admindocs/utils.py has a link_base argument set to "../.." — that works fine if the the link being created is in either the model_detail or view_detail view. But if the view is being created in the tag_index or detail_index the url does not resolve correctly.
The attached patch is a solid solution, but possibly temporary. It simply has the tag_index and model_index views pass parse_rst a link_base kwarg set to the correct relative URL. I think a better solution would be to have the roles’ URLs use reverse() rather than be hard-coded. I tried to do that, but it is difficult as reverse() needs views.py to resolve the URL and views.py relies on utils.py. I am sure it can be done, but I couldn’t figure out how.
milestone: |
→ 1.1
|
Triage Stage: |
Unreviewed → Accepted
|
Component: |
Uncategorized → django.contrib.admin
|
Owner: |
changed from nobody to Armin Ronacher
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
Attached a patch that drops
link_base
and reverses the url to the root properly.