Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#8855 closed (duplicate)

Default comment form deficiencies

Reported by: Jarek Zgoda Owned by:
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Default comment form, as found in comments framework, suffers from some basic deficiencies:

  • submit button labels ("Post" and "Preview") are not marked for translation;
  • the input HTML elements (tags) are not closed, effectively prohibiting document validation as XHTML 1.0

Attached patch fixes these two problems and adds minor change in HTTP method declaration for consistency in style.

Attachments (1)

comments-form.html.diff (983 bytes) - added by Jarek Zgoda 11 years ago.
Comment form fixes

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by Jarek Zgoda

Attachment: comments-form.html.diff added

Comment form fixes

comment:1 Changed 11 years ago by

milestone: 1.0
Owner: changed from nobody to
Status: newassigned

I don't know what to do about the translation strings as we are in string freeze but the tags should be fixed.

comment:2 Changed 11 years ago by

Owner: deleted
Status: assignednew

comment:3 Changed 11 years ago by Jacob

milestone: 1.0post-1.0

We'll fix this after 1.0 - can't add strings now.

comment:4 Changed 11 years ago by Malcolm Tredinnick

I agree the XML errors should be fixed, since that could prevent the page from rendering. So I've done that in r8958. But only that. None of the style changes or anything. That can all wait.

comment:5 Changed 11 years ago by Jarek Zgoda

Looking at default templates provided in comments framework I see there's much more places where such things can be found. As this can be effectively worked around using user-provided forms I agree this should wait for post-1.0.

As there are 2 or 3 different kinds of problems here, I'll create separate tickets for each of there problems (translations, XHTML compliance, style consistency) with appropriate patches. After that I'll ask for closing this ticket in favor of detailed tickets.

comment:6 Changed 11 years ago by Jarek Zgoda

Resolution: duplicate
Status: newclosed

Closing this ticket as duplicate in favor of #8868, #8869 and #8870. Each of these tickets solves separate problem found in comment framework templates.

comment:7 Changed 11 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top