Default comment form deficiencies

[Jarek Zgoda]

Default comment form, as found in comments framework, suffers from some basic deficiencies:

• submit button labels ("Post" and "Preview") are not marked for translation;
• the input HTML elements (tags) are not closed, effectively prohibiting document validation as XHTML 1.0

Attached patch fixes these two problems and adds minor change in HTTP method declaration for consistency in style.

[Jarek Zgoda]

Comment form fixes

I don't know what to do about the translation strings as we are in string freeze but the tags should be fixed.

[Jacob]

We'll fix this after 1.0 - can't add strings now.

[Malcolm Tredinnick]

I agree the XML errors should be fixed, since that could prevent the page from rendering. So I've done that in r8958. But only that. None of the style changes or anything. That can all wait.

[Jarek Zgoda]

Looking at default templates provided in comments framework I see there's much more places where such things can be found. As this can be effectively worked around using user-provided forms I agree this should wait for post-1.0.

As there are 2 or 3 different kinds of problems here, I'll create separate tickets for each of there problems (translations, XHTML compliance, style consistency) with appropriate patches. After that I'll ask for closing this ticket in favor of detailed tickets.

[Jarek Zgoda]

Closing this ticket as duplicate in favor of #8868, #8869 and #8870. Each of these tickets solves separate problem found in comment framework templates.

[(none)]

Milestone post-1.0 deleted