Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8870 closed (fixed)

Templates in comments framework are not compliant with Django style

Reported by: zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:


In all templates in comment framework all froms have HTTP method uppercased. This is not compliant with style of other Django components. Attached patch fixes this issue.

Attachments (1)

contrib-comments-templates-style.diff (5.7 KB) - added by zgoda 7 years ago.
Style fix for templates in comments framework

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by zgoda

Style fix for templates in comments framework

comment:1 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [9050]) Fixed #8870 -- Changed django.contrib.comments templates to use lowercase 'post' for <form method> attributes, to be consistent with our other templates. Thanks, zgoda

comment:2 Changed 7 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top