Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#8870 closed (fixed)

Templates in comments framework are not compliant with Django style

Reported by: Jarek Zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


In all templates in comment framework all froms have HTTP method uppercased. This is not compliant with style of other Django components. Attached patch fixes this issue.

Attachments (1)

contrib-comments-templates-style.diff (5.7 KB) - added by Jarek Zgoda 11 years ago.
Style fix for templates in comments framework

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Jarek Zgoda

Style fix for templates in comments framework

comment:1 Changed 11 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [9050]) Fixed #8870 -- Changed django.contrib.comments templates to use lowercase 'post' for <form method> attributes, to be consistent with our other templates. Thanks, zgoda

comment:2 Changed 10 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top