Code

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#8870 closed (fixed)

Templates in comments framework are not compliant with Django style

Reported by: zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

In all templates in comment framework all froms have HTTP method uppercased. This is not compliant with style of other Django components. Attached patch fixes this issue.

Attachments (1)

contrib-comments-templates-style.diff (5.7 KB) - added by zgoda 6 years ago.
Style fix for templates in comments framework

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by zgoda

Style fix for templates in comments framework

comment:1 Changed 6 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [9050]) Fixed #8870 -- Changed django.contrib.comments templates to use lowercase 'post' for <form method> attributes, to be consistent with our other templates. Thanks, zgoda

comment:2 Changed 5 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.