#8828 closed (fixed)
Fix whitespace issue
Reported by: | jam | Owned by: | Brian Rosner |
---|---|---|---|
Component: | Uncategorized | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I ran into a problem using Rietveld on Google App Engine after updating to revision 8816. I'm attaching a patch that fixes the issue.
Attachments (1)
Change History (4)
by , 16 years ago
Attachment: | django1.diff added |
---|
comment:1 by , 16 years ago
Can you please clarify what "a problem" means? The code there, even with the bonus whitespace is perfectly legal Python. Does Google App Engine have some weird (different from normal Python) parsing rules that is causing this to break?
comment:2 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 16 years ago
Sorry, I thought I copied and pasted the error from App Engine but I had only do that in a private email. Here is the error I was getting, the line it mentioned was the one that had whitespace.
Loading main, app version = 2.156
django.file = '/base/data/home/apps/reviewstest/2.156/django.zip/django/init.py', django.VERSION = (1, 0, 'rc_1')
<type 'exceptions.SyntaxError'>: invalid syntax (widgets.py, line 674)
Traceback (most recent call last):
File "/base/data/home/apps/reviewstest/2.156/main.py", line 74, in <module>
import django.forms
File "/base/data/home/apps/reviewstest/2.156/py_zipimport.py", line 239, in load_module
exec code in mod.dict
File "/base/data/home/apps/reviewstest/2.156/init.py", line 14, in <module>
File "/base/data/home/apps/reviewstest/2.156/py_zipimport.py", line 230, in load_module
code = compile(source, fullpath, 'exec')
<type 'exceptions.SyntaxError'>: invalid syntax (widgets.py, line 674)
Running on yqnd41:4002 statusz INFO
Fix (note it says no newline at the end of the file, but I do have one)