Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8828 closed (fixed)

Fix whitespace issue

Reported by: jam Owned by: brosner
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


I ran into a problem using Rietveld on Google App Engine after updating to revision 8816. I'm attaching a patch that fixes the issue.

Attachments (1)

django1.diff (406 bytes) - added by jam 7 years ago.
Fix (note it says no newline at the end of the file, but I do have one)

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by jam

Fix (note it says no newline at the end of the file, but I do have one)

comment:1 Changed 7 years ago by mtredinnick

Can you please clarify what "a problem" means? The code there, even with the bonus whitespace is perfectly legal Python. Does Google App Engine have some weird (different from normal Python) parsing rules that is causing this to break?

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8911]) Fixed #8828 -- Trimmed some trailing whitespace that might have been causing a
problem for Google AppEngine.

comment:3 Changed 7 years ago by jam

Sorry, I thought I copied and pasted the error from App Engine but I had only do that in a private email. Here is the error I was getting, the line it mentioned was the one that had whitespace.

Loading main, app version = 2.156
django.file = '/base/data/home/apps/reviewstest/2.156/', django.VERSION = (1, 0, 'rc_1')
<type 'exceptions.SyntaxError'>: invalid syntax (, line 674)
Traceback (most recent call last):

File "/base/data/home/apps/reviewstest/2.156/", line 74, in <module>

import django.forms

File "/base/data/home/apps/reviewstest/2.156/", line 239, in load_module

exec code in mod.dict

File "/base/data/home/apps/reviewstest/2.156/", line 14, in <module>

File "/base/data/home/apps/reviewstest/2.156/", line 230, in load_module

code = compile(source, fullpath, 'exec')

<type 'exceptions.SyntaxError'>: invalid syntax (, line 674)

Running on yqnd41:4002 statusz INFO

Note: See TracTickets for help on using tickets.
Back to Top