Opened 16 years ago
Closed 14 years ago
#8778 closed (fixed)
validate_unique - different phrases have the same translations
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | Internationalization | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the new function validate_unique from [8805] two new translations phrases are added. One for one field (unique), one for more fields (unique_together). There is a difference in code - in the first phrase "field_label" variable is used, in the second phrase "field_labels" variable is used. But in the translation strings only "field_label" is used. It means that for some languages (at least for mine) it is almost impossible to have nice translations of these strings. Could it be possible to change the second "field_label" to "field_labels"?
Attachments (2)
Change History (7)
by , 16 years ago
| Attachment: | validate-unique-field-labels.diff added |
|---|
comment:1 by , 16 years ago
| milestone: | 1.0 → post-1.0 |
|---|
by , 16 years ago
| Attachment: | 00-unique-together-field-labels.diff added |
|---|
comment:3 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
follow-up: 5 comment:4 by , 14 years ago
We missed the chance of fixing this for 1.1, for 1.2 this has been solved by the model validation branch merge that also interoduced some refactoring on the modelform validation code.
I'm leaving this ticket open because I'm not sure if we can change/add translatable literals in the 1.1.x maintenance branch. If we can't then please close this ticket.
comment:5 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to ramiro:
I'm leaving this ticket open because I'm not sure if we can change/add translatable literals in the 1.1.x maintenance branch. If we can't then please close this ticket.
I confirmed with Jannis Leidel via IRC that we can't change or add literals in 1.1.x because we can't require translators to update translations there.
Closing ticket as fixed then.
That was a deliberate choice -- with string freeze on we're making as few changes as possible for 1.0. We'll fix this after when we can make more string changes without messing with translators' heads.