Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#8716 closed (fixed)

When a authenticated user post a comments, the field's form is not populate with data of user

Reported by: jmad Owned by: jmad
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

When a authenticated user post a comments, the field's form is not populate with full name and email of the user. This bug stems from the fact that the code is testing if "name" and "email" are present or not in "Data". If they are not present, then the code uses data from the user. Ors these two fields are always present in "data". It must test if they are empty or not and not if they are present.

This bug is in svn and beta 2 version.

Attachments (1)

patch_comments.diff (725 bytes) - added by jmad 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by jmad

comment:1 Changed 6 years ago by jmad

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to jmad
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 6 years ago by anonymous

  • milestone set to 1.0

comment:3 Changed 6 years ago by mtredinnick

  • Triage Stage changed from Unreviewed to Accepted

The standard way to test if a dictionary key has non-empty content is if data["name"]: .... The patch style looks more like C and makes the reader wonder why it's trying to do something special.

comment:4 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8751]) Fixed #8716: correctly handle name and email in comments from authenticated users.

comment:5 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.