Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8712 closed Uncategorized (wontfix)

6.25kB of trailing whitespace in Django code

Reported by: Piotr Lewandowski <django@…> Owned by: nobody
Component: Uncategorized Version: master
Severity: Normal Keywords:
Cc: jwilk@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:


$ grep --only-matching --no-file --recursive --extended-regexp --include='*.py' '[[:space:]]+$' django-trunk | wc -c

Change History (5)

comment:1 Changed 7 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

This isn't worth doing as a single thing. It's a small amount of space and we (the committers) tend to remove it when we're in the area. Doing it as a huge patch just changes the output of "svn annotate" without a really strong reason, which can make debugging harder. There's no impact on the code with this whitespace present, so thanks, but it's fine as it is.

comment:2 Changed 7 years ago by Piotr Lewandowski <django@…>

My real intent when opening this ticket was to draw your (the commiters) attention to this issue, rather than had it solved in one commit. After all, Django is meant to be a framework for perfectionists. :-)

comment:3 Changed 7 years ago by ramiro

From what I've seen while working with patches for the Django code tree, It seems the text editors of some core committers (Jacob comes to mind) are configured so they:

  • Don't truncate extra spaces from the end of files and
  • Don't make sure all files end with a new line

comment:4 Changed 4 years ago by jwilk

  • Cc jwilk@… added
  • Easy pickings unset
  • Severity set to Normal
  • Type set to Uncategorized

comment:5 Changed 4 years ago by ubanus@…

  • Cc ubanus@… removed
Note: See TracTickets for help on using tickets.
Back to Top