Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8680 closed (fixed)

gis may break Python help() modules command

Reported by: kmtracey Owned by: nobody
Component: GIS Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


As reported here:

This is similar to #5743 and perhaps could use a similar approach to fix?

Attachments (1)

8680.patch (766 bytes) - added by gkelly 8 years ago.
Patch to raise different exception that allows Python's help to finish.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by gkelly

Patch to raise different exception that allows Python's help to finish.

comment:1 Changed 8 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8727]) Fixed #8680 -- Changed a couple of GEOExceptions to Python's RuntimeError so
that help() works. Without this change, even if you didn't use the gis stuff,
just using Python 2.5's help() system would crash when searching for model

comment:2 Changed 8 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

As noted in #5743, our policy is not to break help() for everybody just because we're installed, so this had to be fixed. There's a full explanation in the earlier tickets (where people were playing "why is Malcolm so dumb he can't understand this" and using sock puppets to teach me the way forwards).

Justin: I somewhat arbitrarily chose RuntimeError (the choices are RuntimeError and ImportError), but if you want to make a subclass of GEOSException and RuntimeError because you really want to be able to catch the former, go for it.

comment:3 Changed 8 years ago by mtredinnick

(In [8728]) Changed [8727] to use ImportError, which seems to actually work. Not sure what
I was smoking when I tested this 10 minutes ago. Refs #8680. Thanks to gkelly
for cleaning up after me.

comment:4 Changed 5 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top