#8679 closed (fixed)
Custom save() method signature needs to be fixed in some tests and docs after changeset 8670
| Reported by: | Ville Säävuori | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Keywords: | documentation, save, create, get_or_create | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Changeset r8670 change the way create() and get_or_create() methods work. Examples in documentation does not reflect this change yet.
Attachments (1)
Change History (7)
comment:1 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 16 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
At least following files still have wrong signature:
docs/ref/contrib/sitemaps.txtdocs/topics/db/models.txt
by , 16 years ago
| Attachment: | 8679.docs-tests-save.diff added |
|---|
comment:4 by , 16 years ago
| Has patch: | set |
|---|---|
| Summary: | Documentation on custom save() method wrong after changeset 8670 → Custom save() method signature needs to be fixed in some tests and docs after changeset 8670 |
| Triage Stage: | Unreviewed → Accepted |
Thanks for pointing out the specific files. I've also fixed some tests.
comment:5 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
(fixed in [8754], though I didn't add the test changes; those tests pass as-is, which means they don't really need to change; if someone wants to argue that they should, that's a matter for another ticket)
Note:
See TracTickets
for help on using tickets.
This should have been fixed in #8689. Things go fast in the Django world ;)