Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8679 closed (fixed)

Custom save() method signature needs to be fixed in some tests and docs after changeset 8670

Reported by: Ville Säävuori Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: documentation, save, create, get_or_create
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Changeset r8670 change the way create() and get_or_create() methods work. Examples in documentation does not reflect this change yet.

Attachments (1)

8679.docs-tests-save.diff (4.1 KB) - added by Julien Phalip 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Julien Phalip

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: fixed
Status: newclosed

This should have been fixed in #8689. Things go fast in the Django world ;)

comment:2 Changed 8 years ago by Julien Phalip

Sorry I meant [8689].

comment:3 Changed 8 years ago by Ville Säävuori

Resolution: fixed
Status: closedreopened

At least following files still have wrong signature:

  • docs/ref/contrib/sitemaps.txt
  • docs/topics/db/models.txt

Changed 8 years ago by Julien Phalip

Attachment: 8679.docs-tests-save.diff added

comment:4 Changed 8 years ago by Julien Phalip

Has patch: set
Summary: Documentation on custom save() method wrong after changeset 8670Custom save() method signature needs to be fixed in some tests and docs after changeset 8670
Triage Stage: UnreviewedAccepted

Thanks for pointing out the specific files. I've also fixed some tests.

comment:5 Changed 8 years ago by James Bennett

Resolution: fixed
Status: reopenedclosed

(fixed in [8754], though I didn't add the test changes; those tests pass as-is, which means they don't really need to change; if someone wants to argue that they should, that's a matter for another ticket)

comment:6 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top