Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8668 closed (fixed)

Serializer regressions tests broken with MySQL

Reported by: Malcolm Tredinnick Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Looks like [8676] had some side-effects. The serializer regressions tests (serializers_regress) are broken on MySQL and worked before it.

I haven't looked any further than just bisecting down to the problem commit (I thought it was something else I'd done tonight). But if I don't file this now, there'll be a ticket opened in the morning by the Florida Testing Society. Just saving some time by doing it now.

Change History (4)

comment:1 Changed 8 years ago by Jacob

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

I have a sneaking suspicion it's a broken test and not the actual fix in [8676]...

comment:2 Changed 8 years ago by Jacob

Nope, the test's fine; it's a -- wait for it -- bug with MySQL:

mysql> CREATE TABLE thing (id integer AUTO_INCREMENT PRIMARY KEY, data longtext);
Query OK, 0 rows affected (0.00 sec)

mysql> INSERT INTO thing VALUES (0, 'some test');
Query OK, 1 row affected (0.00 sec)

mysql> SELECT * FROM thing;
| id | data      |
|  1 | some test | 


comment:3 Changed 8 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [8703]) Fixed #8668: prevent MySQL from running the new test from [8676].

comment:4 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top