Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#8668 closed (fixed)

Serializer regressions tests broken with MySQL

Reported by: mtredinnick Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Looks like [8676] had some side-effects. The serializer regressions tests (serializers_regress) are broken on MySQL and worked before it.

I haven't looked any further than just bisecting down to the problem commit (I thought it was something else I'd done tonight). But if I don't file this now, there'll be a ticket opened in the morning by the Florida Testing Society. Just saving some time by doing it now.

Attachments (0)

Change History (4)

comment:1 Changed 6 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I have a sneaking suspicion it's a broken test and not the actual fix in [8676]...

comment:2 Changed 6 years ago by jacob

Nope, the test's fine; it's a -- wait for it -- bug with MySQL:

mysql> CREATE TABLE thing (id integer AUTO_INCREMENT PRIMARY KEY, data longtext);
Query OK, 0 rows affected (0.00 sec)

mysql> INSERT INTO thing VALUES (0, 'some test');
Query OK, 1 row affected (0.00 sec)

mysql> SELECT * FROM thing;
+----+-----------+
| id | data      |
+----+-----------+
|  1 | some test | 
+----+-----------+

Awesome.

comment:3 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [8703]) Fixed #8668: prevent MySQL from running the new test from [8676].

comment:4 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.