Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8520 closed (fixed)

password_change() got an unexpected keyword argument 'post_save_redirect'

Reported by: kmtracey Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: password_change(), got, an, unexpected, keyword, argument, 'template_name' Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


As reported on the user's list:

the admin change password link generates an exception. This was introducted in [8473]. The new parameter to change_password was called 'post_change_redirect' in change_password itself but 'post_save_redirect' in the code that attempts to pass in the new parameter. I'll attach a patch that uses the change_password name consistently.

Attachments (1)

redirect.diff (561 bytes) - added by kmtracey 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by kmtracey

comment:1 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [8523]) Fixed #8520 -- Corrected a dumb typo in the call to password_change in django/contrib/admin/ Thanks Karen Tracey for catching this.

comment:2 Changed 7 years ago by anonymous

  • Cc password_change() got an unexpected keyword argument 'template_name' added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:3 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top