Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#8493 closed (fixed)

NoReverseMatch error on password_change_done when changing passwords in the admin interface

Reported by: mtrichardson Owned by: nobody
Component: contrib.admin Version: dev
Severity: Keywords: aug22sprint
Cc: adam@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

admin.sites.root passes password_change information off to contrib.auth, which then calls reverse('django.contrib.auth.password_change_done') to figure out where to 302 the user. However, that fails since that function is not actually hooked up in any urlconf - any admin apps are a thin layer in front of contrib.auth and don't actually associate any urls. This effectively means that any admin's change password functionality is broken - the password is actually changed, but you get a nasty 500 during the process.

Attachments (2)

8493.hackish_try_except_to_get_admin_working.diff (1.5 KB ) - added by mtrichardson 16 years ago.
If there's a NoReverseMatch, catch it and HttpResponseRedirect to a relative path of 'done/'. *shudder*
8493_special_admin_password_change.1.diff (4.4 KB ) - added by Brian Rosner 16 years ago.
better patch that has a new feature side-effect

Download all attachments as: .zip

Change History (7)

comment:1 by RobotAdam, 16 years ago

Cc: adam@… added

by mtrichardson, 16 years ago

If there's a NoReverseMatch, catch it and HttpResponseRedirect to a relative path of 'done/'. *shudder*

comment:2 by mtrichardson, 16 years ago

Keywords: aug22sprint added

by Brian Rosner, 16 years ago

better patch that has a new feature side-effect

comment:3 by Brian Rosner, 16 years ago

I added a keyword argument to the other views for consistency.

comment:4 by Brian Rosner, 16 years ago

Resolution: fixed
Status: newclosed

(In [8473]) Fixed #8493 -- Fixed a NoReverseMatch when redirecting to password_change/done/ in the admin. Added the ability to override redirects to other password change views for consistency. Thanks for the report mtrichardson.

comment:5 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top