#8493 closed (fixed)
NoReverseMatch error on password_change_done when changing passwords in the admin interface
| Reported by: | mtrichardson | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | aug22sprint | |
| Cc: | adam@… | Triage Stage: | Unreviewed |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
admin.sites.root passes password_change information off to contrib.auth, which then calls reverse('django.contrib.auth.password_change_done') to figure out where to 302 the user. However, that fails since that function is not actually hooked up in any urlconf - any admin apps are a thin layer in front of contrib.auth and don't actually associate any urls. This effectively means that any admin's change password functionality is broken - the password is actually changed, but you get a nasty 500 during the process.
Attachments (2)
Change History (7)
comment:1 by , 17 years ago
| Cc: | added |
|---|
by , 17 years ago
| Attachment: | 8493.hackish_try_except_to_get_admin_working.diff added |
|---|
comment:2 by , 17 years ago
| Keywords: | aug22sprint added |
|---|
by , 17 years ago
| Attachment: | 8493_special_admin_password_change.1.diff added |
|---|
better patch that has a new feature side-effect
comment:4 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
If there's a NoReverseMatch, catch it and HttpResponseRedirect to a relative path of 'done/'. *shudder*