Opened 8 years ago

Closed 8 years ago

#8461 closed (wontfix) reset crashes running initial SQL if there's a #comment on the same line as valid SQL

Reported by: niccl Owned by: nobody
Component: Core (Management commands) Version: master
Severity: Keywords:
Cc: Triage Stage: Someday/Maybe
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description reset can run initial SQL. If this SQL has valid SQL at the start, followed by a # comment, then it will fail with
_mysql_exceptions.ProgrammingError: (2014, "Commands out of sync; you can't run this command now")

It fails because the regex in doesn't check for '# comment' when parsing the SQL file. '# comment' is valid in (at least) MySQL.

Attachments (1)

sql_py.diff (666 bytes) - added by niccl 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by niccl

Attachment: sql_py.diff added

comment:1 Changed 8 years ago by niccl

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Doh. finger trouble selecting component

comment:2 Changed 8 years ago by Thomas Kerpe

Resolution: wontfix
Status: newclosed
Triage Stage: UnreviewedSomeday/Maybe

The only types of supported comments for all databases (sqlite,MySQL and PostgreSQL) are:

-- for single line comments
/* … */ for multiline comments

These two are standard compliant

# is a MySQL only extension

Note: See TracTickets for help on using tickets.
Back to Top