Opened 8 years ago

Closed 6 years ago

#8323 closed (duplicate)

British local flavor package named inconsistently

Reported by: Fraser Nevett Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I just noticed that according to the local flavor documentation, the packages are named using the ISO 3166 country codes. However, at present, the British local flavor is within a package called "uk" (United Kingdom) rather than "gb" (Great Britain), which would seem to be the correct 2 letter code.

This is a pretty minor issue as no other country has been assigned "uk" as a country code at this time.

For consistency, we may want to rename the package to "gb". If so, this should probably be done prior to 1.0 to avoid compatibility issues in the future. If it is decided that the name should be left as is, then I think the documentation should at least be updated to mention this legacy naming anomaly.

All the other local flavors appear to be using the correct ISO codes.

Change History (3)

comment:1 Changed 8 years ago by Alex Gaynor

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 7 years ago by Tobias McNulty

This is a pain for code that tries to automatically find the localflavor packages by ISO. Here's my vote to get this fixed.

comment:3 Changed 6 years ago by Fraser Nevett

Resolution: duplicate
Status: newclosed

Closing in favour of #13729, which has been accepted.

Note: See TracTickets for help on using tickets.
Back to Top