Change fields' names in django.contrib.localflavor.pl.forms

[Piotr Lewandowski <django@…>]

I would like to propose backward incompatible change django.contrib.localflavor.pl.forms:

Some classes present in django.contrib.localflavor.pl.forms are named in a werid way - they are neither short and useful, nor offical translations of corresponding numbers.

Old name	New name
PLNationalIdentificationNumberField	PLPESELField
PLTaxNumberField	PLNIPField
PLNationalBusinessRegisterField	PLREGONField
PLVoivodeshipSelect	PLProvinceSelect
PLAdministrativeUnitSelect	PLCountiesSelect

Not only Polish people in everyday language use those acronyms, but even Polish officials refer to those numbers as PESEL, REGON and NIP:

• ​http://www.mswia.gov.pl/portal/en/1/383/18102007_Meeting_of_G6_Ministers__Invitation_for_Conference.html
• ​http://www.stat.gov.pl/bip/regon_ENG_HTML.htm

I'm willing to prepare the patch if those changes are accepted.

[Malcolm Tredinnick]

Using the "correct" names sounds right and, failing any other indication, the common usage is correct. So this seems reasonable. I'll get it in before the beta.

[Piotr Lewandowski <django@…>]

Malcolm, can you also take a look at ticket #8197? Are there any chances to get that in before the beta?

PLCountiesSelect (aka PLAdministrativeUnitSelect) is using outdated counties list - I don't know whether it's worth filling separate ticket.

In the long run, fields like PLProvinceSelect, PLCountiesSelect and not-yet-existing PLCommunesSelect and PLCitiesSelect could use data from pl_regions.py introduced in #8197 so they'd be up-to-date. I may prepare a path combining this feature and issues mentioned in #8197 and #8276.

[Malcolm Tredinnick]

#8197 is unrelated to this ticket. Adding new stuff like that can wait, since there are design questions there.

[Malcolm Tredinnick]

(In [8345]) Fixed #8276 -- Changed the names of a few Polish localflavor classes to match
their common names/acronyms, similar to other localflavors.

Backwards incompatible if you're using these classes.

[Piotr Lewandowski <django@…>]

My mistake - PLCountiesSelect should be rather named PLCountySelect - to be coherent with ro and uk localflavors.

[Manuel Saelices]

A patch that fixes typo error

[Piotr Lewandowski <django@…>]

Previous patch does not include tests

[Jacob]

(In [8643]) Fixed #8276: corrected another couple of names in localflavor.pl.forms. Patch by Piotr Lewandowski.

[Jacob]

Milestone 1.0 deleted