#8276 closed Uncategorized (fixed)
Change fields' names in django.contrib.localflavor.pl.forms
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | contrib.localflavor | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I would like to propose backward incompatible change django.contrib.localflavor.pl.forms
:
Some classes present in django.contrib.localflavor.pl.forms
are named in a werid way - they are neither short and useful, nor offical translations of corresponding numbers.
Old name | New name |
PLNationalIdentificationNumberField | PLPESELField
|
PLTaxNumberField | PLNIPField
|
PLNationalBusinessRegisterField | PLREGONField
|
PLVoivodeshipSelect | PLProvinceSelect
|
PLAdministrativeUnitSelect | PLCountiesSelect
|
Not only Polish people in everyday language use those acronyms, but even Polish officials refer to those numbers as PESEL
, REGON
and NIP
:
- http://www.mswia.gov.pl/portal/en/1/383/18102007_Meeting_of_G6_Ministers__Invitation_for_Conference.html
- http://www.stat.gov.pl/bip/regon_ENG_HTML.htm
I'm willing to prepare the patch if those changes are accepted.
Attachments (2)
Change History (13)
comment:1 by , 16 years ago
milestone: | → 1.0 beta |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 16 years ago
Malcolm, can you also take a look at ticket #8197? Are there any chances to get that in before the beta?
PLCountiesSelect
(aka PLAdministrativeUnitSelect
) is using outdated counties list - I don't know whether it's worth filling separate ticket.
In the long run, fields like PLProvinceSelect
, PLCountiesSelect
and not-yet-existing PLCommunesSelect
and PLCitiesSelect
could use data from pl_regions.py
introduced in #8197 so they'd be up-to-date. I may prepare a path combining this feature and issues mentioned in #8197 and #8276.
comment:3 by , 16 years ago
#8197 is unrelated to this ticket. Adding new stuff like that can wait, since there are design questions there.
comment:4 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 by , 16 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
My mistake - PLCountiesSelect
should be rather named PLCountySelect
- to be coherent with ro
and uk
localflavors.
comment:6 by , 16 years ago
Has patch: | set |
---|
comment:7 by , 16 years ago
milestone: | 1.0 beta → 1.0 |
---|
comment:8 by , 16 years ago
Cc: | added |
---|
comment:9 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:10 by , 14 years ago
Cc: | removed |
---|---|
Easy pickings: | unset |
Severity: | → Normal |
Type: | → Uncategorized |
Using the "correct" names sounds right and, failing any other indication, the common usage is correct. So this seems reasonable. I'll get it in before the beta.