Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8276 closed Uncategorized (fixed)

Change fields' names in django.contrib.localflavor.pl.forms

Reported by: Piotr Lewandowski <django@…> Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:

Description

I would like to propose backward incompatible change django.contrib.localflavor.pl.forms:

Some classes present in django.contrib.localflavor.pl.forms are named in a werid way - they are neither short and useful, nor offical translations of corresponding numbers.

Old nameNew name
PLNationalIdentificationNumberFieldPLPESELField
PLTaxNumberFieldPLNIPField
PLNationalBusinessRegisterFieldPLREGONField
PLVoivodeshipSelectPLProvinceSelect
PLAdministrativeUnitSelectPLCountiesSelect

Not only Polish people in everyday language use those acronyms, but even Polish officials refer to those numbers as PESEL, REGON and NIP:

I'm willing to prepare the patch if those changes are accepted.

Attachments (2)

polish_forms_r8521.diff (891 bytes) - added by msaelices 7 years ago.
A patch that fixes typo error
polish_form_r8522.diff (20.9 KB) - added by Piotr Lewandowski <django@…> 7 years ago.
Previous patch does not include tests

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by mtredinnick

  • milestone set to 1.0 beta
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Using the "correct" names sounds right and, failing any other indication, the common usage is correct. So this seems reasonable. I'll get it in before the beta.

comment:2 Changed 7 years ago by Piotr Lewandowski <django@…>

Malcolm, can you also take a look at ticket #8197? Are there any chances to get that in before the beta?

PLCountiesSelect (aka PLAdministrativeUnitSelect) is using outdated counties list - I don't know whether it's worth filling separate ticket.

In the long run, fields like PLProvinceSelect, PLCountiesSelect and not-yet-existing PLCommunesSelect and PLCitiesSelect could use data from pl_regions.py introduced in #8197 so they'd be up-to-date. I may prepare a path combining this feature and issues mentioned in #8197 and #8276.

comment:3 Changed 7 years ago by mtredinnick

#8197 is unrelated to this ticket. Adding new stuff like that can wait, since there are design questions there.

comment:4 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8345]) Fixed #8276 -- Changed the names of a few Polish localflavor classes to match
their common names/acronyms, similar to other localflavors.

Backwards incompatible if you're using these classes.

comment:5 Changed 7 years ago by Piotr Lewandowski <django@…>

  • Resolution fixed deleted
  • Status changed from closed to reopened

My mistake - PLCountiesSelect should be rather named PLCountySelect - to be coherent with ro and uk localflavors.

Changed 7 years ago by msaelices

A patch that fixes typo error

comment:6 Changed 7 years ago by msaelices

  • Has patch set

Changed 7 years ago by Piotr Lewandowski <django@…>

Previous patch does not include tests

comment:7 Changed 7 years ago by mtredinnick

  • milestone changed from 1.0 beta to 1.0

comment:8 Changed 7 years ago by Jakub Wilk <ubanus@…>

  • Cc ubanus@… added

comment:9 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [8643]) Fixed #8276: corrected another couple of names in localflavor.pl.forms. Patch by Piotr Lewandowski.

comment:10 Changed 4 years ago by ubanus@…

  • Cc ubanus@… removed
  • Easy pickings unset
  • Severity set to Normal
  • Type set to Uncategorized

comment:11 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top