Code

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#8275 closed (fixed)

Unused and unnecessary imports in auth views

Reported by: julien Owned by: nobody
Component: contrib.auth Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Attached patch removes those.

Attachments (1)

8275.unused_imports.diff (2.4 KB) - added by julien 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by julien

comment:1 Changed 6 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Below each of the lines where you removed the settings import is a line that uses the settings.

comment:2 Changed 6 years ago by julien

Yes, but settings is already imported at the top of the file, so all the imports inside the views are unnecessary.

comment:3 Changed 6 years ago by mtredinnick

  • milestone set to 1.0
  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 6 years ago by ubernostrum

  • milestone changed from 1.0 to 1.0 maybe

Since this is cosmetic, I'm dropping it back to "maybe".

comment:5 Changed 6 years ago by jacob

  • milestone changed from 1.0 maybe to post-1.0

Purely cosmetic - pushing post-1.0.

comment:6 Changed 5 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:7 Changed 5 years ago by russ

  • Resolution set to fixed
  • Status changed from new to closed

The latest SVN version doesn't have the extra import statements. Fixed by r8386.

comment:8 Changed 5 years ago by russ

Oops, sorry -- I ought to have read the rules carefully, first. I should have set this to worksforme, since I'm certainly no core developer. My mistake!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.