Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8275 closed (fixed)

Unused and unnecessary imports in auth views

Reported by: Julien Phalip Owned by: nobody
Component: contrib.auth Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Attached patch removes those.

Attachments (1)

8275.unused_imports.diff (2.4 KB) - added by Julien Phalip 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Julien Phalip

Attachment: 8275.unused_imports.diff added

comment:1 Changed 8 years ago by anonymous

Below each of the lines where you removed the settings import is a line that uses the settings.

comment:2 Changed 8 years ago by Julien Phalip

Yes, but settings is already imported at the top of the file, so all the imports inside the views are unnecessary.

comment:3 Changed 8 years ago by Malcolm Tredinnick

milestone: 1.0
Triage Stage: UnreviewedAccepted

comment:4 Changed 8 years ago by James Bennett

milestone: 1.01.0 maybe

Since this is cosmetic, I'm dropping it back to "maybe".

comment:5 Changed 8 years ago by Jacob

milestone: 1.0 maybepost-1.0

Purely cosmetic - pushing post-1.0.

comment:6 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:7 Changed 8 years ago by russ

Resolution: fixed
Status: newclosed

The latest SVN version doesn't have the extra import statements. Fixed by r8386.

comment:8 Changed 8 years ago by russ

Oops, sorry -- I ought to have read the rules carefully, first. I should have set this to worksforme, since I'm certainly no core developer. My mistake!

Note: See TracTickets for help on using tickets.
Back to Top