Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8253 closed (fixed)

Regression: Atom feed lacks xmlns root attribute

Reported by: eibaan Owned by: jacob
Component: contrib.syndication Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Since [8311], the atom feed has no xmlns declaration anymore. The attached patch fixes the problem and adds an regression test.

Attachments (2)

r8319_atom.patch (1.1 KB) - added by eibaan@… 7 years ago.
feed_root_attributes.diff (2.8 KB) - added by jbronn 7 years ago.
Allows customization of RSS element attributes (w/tests); re-enables XMLNS suport for Atom feeds.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by eibaan@…

comment:1 Changed 7 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to jacob
  • Patch needs improvement unset
  • Status changed from new to assigned

Changed 7 years ago by jbronn

Allows customization of RSS element attributes (w/tests); re-enables XMLNS suport for Atom feeds.

comment:2 follow-up: Changed 7 years ago by jacob

  • milestone set to 1.0
  • Triage Stage changed from Unreviewed to Accepted

Restating from IRC: both "root_attributes" *and* "root_element_attributes" is confusing. Maybe "root_attributes" and "feed_attributes"?

comment:3 in reply to: ↑ 2 Changed 7 years ago by jbronn

Replying to jacob:

Restating from IRC: both "root_attributes" *and* "root_element_attributes" is confusing. Maybe "root_attributes" and "feed_attributes"?

Already updated the patch uses rss_attributes for the RSS-specific options.

comment:4 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8331]) Fixed #8253: fixed xmlns regression for Atom feeds, and in the process added a hook for adding attributes specifically on the root <rss> element (for RSS feeds only, of course). Patch by Justin Bronn.

comment:5 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top