Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#8253 closed (fixed)

Regression: Atom feed lacks xmlns root attribute

Reported by: eibaan Owned by: Jacob
Component: contrib.syndication Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Since [8311], the atom feed has no xmlns declaration anymore. The attached patch fixes the problem and adds an regression test.

Attachments (2)

r8319_atom.patch​ (1.1 KB ) - added by eibaan@… 16 years ago.
feed_root_attributes.diff​ (2.8 KB ) - added by jbronn 16 years ago.
Allows customization of RSS element attributes (w/tests); re-enables XMLNS suport for Atom feeds.

Download all attachments as: .zip

Change History (7)

by eibaan@…, 16 years ago

Attachment: r8319_atom.patch​ added

comment:1 by Jacob, 16 years ago

Owner: changed from nobody to Jacob
Status: new → assigned

by jbronn, 16 years ago

Attachment: feed_root_attributes.diff​ added

Allows customization of RSS element attributes (w/tests); re-enables XMLNS suport for Atom feeds.

comment:2 by Jacob, 16 years ago

milestone: → 1.0
Triage Stage: Unreviewed → Accepted

Restating from IRC: both "root_attributes" *and* "root_element_attributes" is confusing. Maybe "root_attributes" and "feed_attributes"?

in reply to:  2 comment:3 by jbronn, 16 years ago

Replying to jacob:

Restating from IRC: both "root_attributes" *and* "root_element_attributes" is confusing. Maybe "root_attributes" and "feed_attributes"?

Already updated the patch uses rss_attributes for the RSS-specific options.

comment:4 by Jacob, 16 years ago

Resolution: → fixed
Status: assigned → closed

(In [8331]) Fixed #8253: fixed xmlns regression for Atom feeds, and in the process added a hook for adding attributes specifically on the root <rss> element (for RSS feeds only, of course). Patch by Justin Bronn.

comment:5 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top