Calling queyset.in_bulk (without any arguments) should evaluate the whole queryset.

[ElliottM]

in_bulk() works well if you know beforehand which ids you want to pull out. It becomes irritating, however, if you want to map an entire queryset at once.

Right now you have to do the following:

id_list=list(Book.objects.filter(author__name='Douglas Adams').values_list('id', flat=True))
bulk=Book.objects.in_bulk(id_list)

With the patch included, the following will now work:

bulk=Book.objects.filter(author__name='Douglas Adams').in_bulk()

I feel the second way is easier to read, and I really don't see any reason why people shouldn't be allowed to do this.

[ElliottM]

patch with test and docs

[Malcolm Tredinnick]

This would be a backwards incompatible API change (the docs say that calling in_bulk() with no parameters returns an empty dictionary).

It's also a one line call to do it yourself (dict([(o.pk, o) for o in qs])), so it doesn't really need to be added to the API.

[anonymous]

​http://docs.djangoproject.com/en/dev/ref/models/querysets/#in-bulk-id-list

"If you pass in_bulk() an empty list, you'll get an empty dictionary."

Passing it an empty list is quite different than passing no parameters at all, so all previous code would be compatible. queryset.in_bulk() is also a lot easier to read than the code snippet you posted.

[(none)]

Milestone post-1.0 deleted

[Adam Nelson]

Any update on this?

[Luke Plant]

This looks like a good idea to me, and not backwards incompatible, as noted by anonymous.

The patch needs work - unittests instead of doctests, and a proper versionadded directive in the docs.

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Tim Graham]

Marking as "Easy pickings" since it looks to me like updating this patch shouldn't be too difficult. Check it with the PatchReviewChecklist.

[Bryan Marty]

Diff
​https://github.com/bxm156/django/commit/5a264a641be2acb15e5f43b8d8420e91a8c9099e

Opened
​https://github.com/django/django/pull/5514

[Bryan Marty]

Updated Diff: ​https://github.com/bxm156/django/commit/513e72a46a19791daeb600e8b3cc29aeb35d206d

PR: ​​https://github.com/django/django/pull/5514

[Tim Graham <timograham@…>]

In 62ca2dea:

Fixed #8065 -- Made id_list an optional argument for QuerySet.in_bulk().