Opened 15 years ago

Closed 12 years ago

#7955 closed Cleanup/optimization (wontfix)

Change popup variable name in django.contrib.admin

Reported by: David Cramer Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


[25/Jul/2008 02:48:19] "GET /admin/businesses/category/?pop=1 HTTP/1.1" 200 2091
[25/Jul/2008 02:48:22] "GET /admin/businesses/category/add/?_popup=1 HTTP/1.1" 200 2913

It'd make sense to have keep them consistent, and use _popup.

Attachments (1)

7955.patch (2.5 KB) - added by Matthias Kestenholz 15 years ago.

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by Matthias Kestenholz

Attachment: 7955.patch added

comment:1 Changed 15 years ago by Matthias Kestenholz

Has patch: set
Triage Stage: UnreviewedAccepted

comment:2 Changed 15 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:3 Changed 14 years ago by mrts

Triage Stage: AcceptedDesign decision needed

_pop is used for changelist popups whereas _popup is used for object popups.

Having this distinction is actually useful, for instance I have a fairly complex use-case where the changelist shows only a subset of objects, but access to single objects is still needed via raw_id_fields popups. Let me exemplify:

class ExposeObject(admin.ModelAdmin):
    def queryset(self, request):
        """Show objects in pop-ups that are not visible via default manager."""
        if request.REQUEST.has_key('_popup'):
            return self.model.all_objects.get_query_set()
            return super(ShowInListAdmin, self).queryset(request)

Changing state to DDN, but I'm personally -0.

comment:4 Changed 12 years ago by Luke Plant

Severity: Normal
Type: Cleanup/optimization

comment:5 Changed 12 years ago by Jacob

Easy pickings: unset
Resolution: wontfix
Status: newclosed
UI/UX: unset

Yeah, this is a bit inconsistant but it doesn't have any actual ramifications so we'll leave it the way it is. If there's an actual bug here this inconstancy causes please feel free to reopen.


Note: See TracTickets for help on using tickets.
Back to Top