Change popup variable name in django.contrib.admin

[David Cramer]

[25/Jul/2008 02:48:19] "GET /admin/businesses/category/?pop=1 HTTP/1.1" 200 2091
[25/Jul/2008 02:48:22] "GET /admin/businesses/category/add/?_popup=1 HTTP/1.1" 200 2913

It'd make sense to have keep them consistent, and use _popup.

[(none)]

Milestone post-1.0 deleted

[mrts]

_pop is used for changelist popups whereas _popup is used for object popups.

Having this distinction is actually useful, for instance I have a fairly complex use-case where the changelist shows only a subset of objects, but access to single objects is still needed via raw_id_fields popups. Let me exemplify:

class ExposeObject(admin.ModelAdmin):
    def queryset(self, request):
        """Show objects in pop-ups that are not visible via default manager."""
        if request.REQUEST.has_key('_popup'):
            return self.model.all_objects.get_query_set()
        else:
            return super(ShowInListAdmin, self).queryset(request)

Changing state to DDN, but I'm personally -0.

[Jacob]

Yeah, this is a bit inconsistant but it doesn't have any actual ramifications so we'll leave it the way it is. If there's an actual bug here this inconstancy causes please feel free to reopen.

Thanks!