Type inconsistency in part 2 of the tutorial

[Ivan Giuliani]

In the "Customize the admin form" section, we have the following code snippet:

class PollAdmin(admin.ModelAdmin):
    fieldsets = [
        (None,               {'fields': ['question']}),
        ('Date information', {'fields': ['pub_date'], 'classes': 'pub_date'}),
    ]

But that should be:

class PollAdmin(admin.ModelAdmin):
    fieldsets = [
        (None,               {'fields': ['question']}),
        ('Date information', {'fields': ['pub_date'], 'classes': ['collapse']}),
    ]

There are two issues here with the classes attribute:

• the argument should be collapse, not pub_date
• and should be an iterable sequence, not a string as in the admin is then rendered as "c o l l a p s e" (iterating over the chars)

Now it's not clear what should be the right behaviour: accept both iterable sequences and strings (by "special casing" them, a if type(sequence) == str: sequence = [sequence] should do the work), or raising some error if the wrong type is passed.

The same error is in the second example of the "Adding related objects" section.

[Jan Rademaker <j.rademaker@…>]

Assuming the documentation is wrong; here's the patch I had already written for #7839.

[Brian Rosner]

Whoops didn't see this. I already closed #7839 with a fix. Closing this one too. Fix was in [7983].

[Ivan Giuliani]

Not completely closed: as I said the classes value should be collapse, not pub_date.

[Ivan Giuliani]

fixes typo in tutorial

[Brian Rosner]

Ah, my bad. Should have read that. Will fix now.

[Brian Rosner]

(In [7984]) Fixed #7838 -- Corrected an invalid class name the 'classes' usage in the tutorial. Thanks kratorius for catching this.