Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#7831 closed (fixed)

get_language_from_request should be case-insensitive while matching settings.LANGUAGES

Reported by: bear330 Owned by: nobody
Component: Internationalization Version: dev
Severity: Keywords: locale, language, case, middleware
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

HTTP_ACCEPT_LANGUAGE sent by browser will be different from its vendor or OS,
for example:
In XP, IE(6 or 7) will send zh-tw, in Vista it will be zh-TW
But firefox2 in some machine will send zh-tw or zh-TW,
In firefox3, it will send zh-tw always. (In my machine).

This will cause this line in trans_real.py failed:

            if lang not in supported:
                continue

It should compare it with case-insensitive way to fulfill all situations.

Thanks.

Attachments (1)

7831.patch​ (533 bytes ) - added by bear330 16 years ago.
Simple patch to fix that.

Download all attachments as: .zip

Change History (5)

by bear330, 16 years ago

Attachment: 7831.patch​ added

Simple patch to fix that.

comment:1 by Karen Tracey <kmtracey@…>, 16 years ago

milestone: → 1.0
Triage Stage: Unreviewed → Accepted

comment:2 by ebruning, 16 years ago

Has patch: set

comment:3 by Jacob, 16 years ago

Resolution: → fixed
Status: new → closed

(In [8561]) Fixed #7831: be case-insensitive when in get_language_from_request.

comment:4 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top