#7830 closed (fixed)
removal of some deprecated features for 1.0
Reported by: | Gary Wilson | Owned by: | |
---|---|---|---|
Component: | Uncategorized | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Attached is a patch that removes:
- "simple" cache backend
ObjectPaginator
edit_inline_type
argument forForeignKey
fields- QOperator, QNot, QAnd and QOr
- maxlength argument
Along with mentions of them in the docs.
Note, the following should also be removed (if applying the patch doesn't do it):
- django/utils/maxlength.py
- tests/regressiontests/maxlength/
Attachments (1)
Change History (16)
by , 16 years ago
Attachment: | deprecated.patch added |
---|
comment:1 by , 16 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|
follow-up: 11 comment:2 by , 16 years ago
comment:3 by , 16 years ago
milestone: | 1.0 alpha → 1.0 beta |
---|
comment:4 by , 16 years ago
Is the auto_now auto_now_add stuff slated for removal(I only ask because if we keep those in then we can't remove them until 2.0 or whenever we next break backwards-compatibility)?
comment:5 by , 16 years ago
comment:6 by , 16 years ago
comment:7 by , 16 years ago
comment:8 by , 16 years ago
Has patch: | unset |
---|---|
Owner: | removed |
Triage Stage: | Ready for checkin → Design decision needed |
The following items are still issuing warnings:
UploadedFile
properties -filename
,file_name
,file_size
, andchunk
. IMO, we should go ahead and remove these; weren't they only around for 6 days ([7814] to [7859])!?- Using uploaded-files-as-dictionaries. This should stay around for 1.0 and be removed next release.
form_for_model
andform_for_instance
. I'm not sure what the latest fate of these two functions are. Anyone have a status update?- Attempting to import
django.newforms
. I assume we are also going to want to keep this for 1.0 and remove next release. - Use of the follow argument in create/update generic views. This should probably get removed as part of #7742.
comment:9 by , 16 years ago
I don't think we can remove in the next release, 1.0 is supposed to mean backward compatibility going forward, aka everything that works on 1.0 will work with 1.1, etc. So I don't think that lets us remove things.
comment:10 by , 16 years ago
Hmm... according to the contributing documentation, it looks like we actually need to remove all deprecated features before 1.0:
"A minor release may deprecate certain features in previous releases. If a feature in version A.B is deprecated, it will continue to work in version A.B+1. In version A.B+2, use of the feature will raise a PendingDeprecationWarning but will continue to work. Version A.B+3 will remove the feature entirely. Major point releases will always remove deprecated features immediately."
follow-up: 12 comment:11 by , 16 years ago
comment:12 by , 16 years ago
Replying to gwilson:
Replying to russellm:
Another list of bits that need to be purged are the oldforms-specific parts of model fields. An incomplete list:
These should probably be removed with #7742, don't you think?
I didn't notice #7742 when I commented on this ticket. Yes, oldforms bits should be removed as part of #7742.
comment:13 by , 16 years ago
Triage Stage: | Design decision needed → Accepted |
---|
comment:14 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [8291]) Fixed #7830 -- Removed all of the remaining, deprecated, non-oldforms features:
- Support for representing files as strings was removed. Use
django.core.files.base.ContentFile
instead. - Support for representing uploaded files as dictionaries was removed. Use
django.core.files.uploadedfile.SimpleUploadedFile
instead. - The
filename
,file_name
,file_size
, andchuck
properties ofUploadedFile
were removed. Use thename
,name
,size
, andchunks
properties instead, respectively. - The
get_FIELD_filename
,get_FIELD_url
,get_FIELD_size
, andsave_FIELD_file
methods for Models withFileField
fields were removed. Instead, use thepath
,url
, andsize
attributes andsave
method on the field itself, respectively. - The
get_FIELD_width
andget_FIELD_height
methods for Models withImageField
fields were removed. Use thewidth
andheight
attributes on the field itself instead. - The dispatcher
connect
,disconnect
,send
, andsendExact
functions were removed. Use the signal object's ownconnect
,disconnect
,send
, andsend
methods instead, respectively. - The
form_for_model
andform_for_instance
functions were removed. Use aModelForm
subclass instead. - Support for importing
django.newforms
was removed. Usedjango.forms
instead. - Support for importing
django.utils.images
was removed. Usedjango.core.files.images
instead. - Support for the
follow
argument in thecreate_object
andupdate_object
generic views was removed. Use thedjango.forms
package and the newform_class
argument instead.
Another list of bits that need to be purged are the oldforms-specific parts of model fields. An incomplete list:
These aren't just in db.models.fields.init.py - they are in a few other locations, too. Doing a search for any method that mentions "manipulator" would be a pretty good starting point for finding the remainder.