Opened 7 years ago

Closed 7 years ago

#7798 closed (duplicate)

django.contrib.auth.tests.PasswordResetTest.test_email_not_found fails when using auth models but using a different view for password reset

Reported by: santiago_aguiar Owned by: devin
Component: Testing framework Version: master
Severity: Keywords:
Cc: devin@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I changed the way password_reset is handled by mapping /password_reset/ to may own view un urlconf and the test started failing since it expects that URL to behave like the stock auth app (and even return a specific error message).

I think the issue goes deep, since external included apps test cases should not perform tests as HTTP clientes (since they don't know how the application that is using the external app actually handles does URLs) or skip them when running as included from another app.

I add the issue under unit test system since even if this particular case is in the contrib.auth app, the problem will surface again if the same testing method is used.

Change History (3)

comment:1 Changed 7 years ago by santiago_aguiar

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Thinking about it again, there's not such thing as a primary app in django, but only a root urlconf, so I can't think of simple ways to solve this, except taking a 'take or leave it' approach on apps.

comment:2 Changed 7 years ago by devin

  • Cc devin@… added
  • Owner changed from nobody to devin

comment:3 Changed 7 years ago by devin

  • Resolution set to duplicate
  • Status changed from new to closed

This has been fixed in [7808].

Note: See TracTickets for help on using tickets.
Back to Top