Opened 8 years ago

Closed 5 years ago

#7758 closed New feature (fixed)

Can't override the form_url for change_view - like you can with add_view

Reported by: Rozza Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords: newforms admin customization
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Refs: #7757

As there is a way to override the form_url for the add_view there should also be a way to override for the change_view.

Use case example - add GET params to the form action so that you can pass GET data as well as post - for callback etc..

Attachments (3)

options.py.patch (1.0 KB) - added by Rozza 8 years ago.
Adds a form_url to the change_view method and then passes it to the render_change_form
7758.patch (2.3 KB) - added by krzysztof.szczesny@… 5 years ago.
form_url is now passed to change_view in admin
7758_2.patch (2.7 KB) - added by krzysztof.szczesny@… 5 years ago.
same as previous but works this time :P

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by Rozza

Attachment: options.py.patch added

Adds a form_url to the change_view method and then passes it to the render_change_form

comment:1 Changed 8 years ago by Eric Holscher

milestone: post-1.0
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:3 Changed 5 years ago by Luke Plant

Severity: Normal
Type: New feature

comment:4 Changed 5 years ago by Alex Gaynor

Easy pickings: unset
Triage Stage: Design decision neededAccepted
UI/UX: unset

comment:5 Changed 5 years ago by Ramiro Morales

Easy pickings: set
Needs documentation: set
Needs tests: set

comment:6 Changed 5 years ago by Julien Phalip

See #17189 for a related issue.

Changed 5 years ago by krzysztof.szczesny@…

Attachment: 7758.patch added

form_url is now passed to change_view in admin

Changed 5 years ago by krzysztof.szczesny@…

Attachment: 7758_2.patch added

same as previous but works this time :P

comment:7 Changed 5 years ago by Tomek Paczkowski

Triage Stage: AcceptedReady for checkin

comment:8 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [17466]:

Fixed #7758 and #17189 -- Allowed to override the form_url context var in the admin change view and the user admin's password change view. Thanks, michal and krzysztof.szczesny.

Note: See TracTickets for help on using tickets.
Back to Top