Opened 7 years ago

Closed 4 years ago

#7757 closed New feature (fixed)

Can't override the form_url for add_view - its not passed to render_change_form

Reported by: Rozza Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Normal Keywords: newforms admin customization
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

form_url is passed to form_url but then not passed to the render_change_form

So you can't override it.

Attachments (1)

options.py.patch (615 bytes) - added by Rozza 7 years ago.
Passes the form_url to render_change_form method

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Rozza

Passes the form_url to render_change_form method

comment:1 Changed 7 years ago by brosner

  • milestone 1.0 alpha deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

The milestone is reserved for triagers to set. Also, what is the purpose of needing to do this?

comment:2 Changed 7 years ago by Rozza

Its currently passed into the add_view but not passed to the template - which wants to use the variable.

So for example you can't pass GET parameters into the form action. Which also may be required as well as POST params.

comment:3 Changed 7 years ago by Rozza

Also please see #7758 as it allows you to manage the form_url for the change_view as well standardising the interface for the methods.

The form_url is then used in the render_change_form method and passed to the template

comment:4 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to New feature

comment:5 Changed 4 years ago by Alex

  • Easy pickings unset
  • Resolution set to fixed
  • Status changed from new to closed
  • UI/UX unset

This was fixed at some point.

Note: See TracTickets for help on using tickets.
Back to Top