Code

Opened 6 years ago

Closed 6 years ago

#7728 closed (fixed)

Test output checking overly detailed

Reported by: fijal Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords:
Cc: fijall@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There is a test in admin scripts that relies that file is loaded from .pyc. This fails on top of pypy and IMO it's not a good thing to have in the first place. Attached patch.

Attachments (1)

test.diff (919 bytes) - added by fijal 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by fijal

comment:1 Changed 6 years ago by fijal

  • Cc fijall@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [7915]) Fixed #7728 -- Modified the output check in the admin script tests. Checking for pyc is a CPython-specific check, and it breaks CPython if pyc files aren't generated (due to permission problems, etc). Thanks to Maciej Fijalkowski (fijal) for the report and fix.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.