Opened 6 years ago

Closed 6 years ago

#7532 closed (fixed)

limit_offset_sql DatabaseOperations method deprecated?

Reported by: ramiro Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords: db-be-api limit offset limit_offset_sql
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Seems that since qs-rf landing other means are now employed to handle LIMIT/OFFSET SQL query components construction and limit_offset_sql() isn't used anymore from anywhere in the Django source tree.

Attached is a patch (against r7732) that drops it.

See also #7319

Attachments (1)

no_limit_offset_sql_r7732.diff (2.7 KB) - added by ramiro 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by ramiro

comment:1 Changed 6 years ago by ramiro

  • Component changed from Uncategorized to Database wrapper
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by Bastian Kleineidam <calvin@…>

Yep, limit_offset_sql() is dead code.

comment:3 Changed 6 years ago by ramiro

  • Keywords db-be-api added

comment:4 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7852]) Fixed #7532 -- Removed some dead code from the db backends. Thanks, Ramiro.

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.