Opened 16 years ago

Closed 16 years ago

#7532 closed (fixed)

limit_offset_sql DatabaseOperations method deprecated?

Reported by: Ramiro Morales Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Keywords: db-be-api limit offset limit_offset_sql
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Seems that since qs-rf landing other means are now employed to handle LIMIT/OFFSET SQL query components construction and limit_offset_sql() isn't used anymore from anywhere in the Django source tree.

Attached is a patch (against r7732) that drops it.

See also #7319

Attachments (1)

no_limit_offset_sql_r7732.diff​ (2.7 KB ) - added by Ramiro Morales 16 years ago.

Download all attachments as: .zip

Change History (5)

by Ramiro Morales, 16 years ago

Attachment: no_limit_offset_sql_r7732.diff​ added

comment:1 by Ramiro Morales, 16 years ago

Component: Uncategorized → Database wrapper

comment:2 by Bastian Kleineidam <calvin@…>, 16 years ago

Yep, limit_offset_sql() is dead code.

comment:3 by Ramiro Morales, 16 years ago

Keywords: db-be-api added

comment:4 by Malcolm Tredinnick, 16 years ago

Resolution: → fixed
Status: new → closed

(In [7852]) Fixed #7532 -- Removed some dead code from the db backends. Thanks, Ramiro.

Note: See TracTickets for help on using tickets.
Back to Top