Opened 8 years ago

Closed 8 years ago

#7319 closed (fixed)

DatabaseFeatures.needs_upper_for_iops is not used anywhere

Reported by: Leo Soto M. Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords: db-be-api
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Doing a grep on the source code, I found that while needs_upper_for_iops is still defined on DatabaseFeatures, its value is not read by anyone. Seems like the feature was made for the oracle case, which now gets the problem around overriding DatabaseOperations.lookup_cast

Attachments (1)

t7319-r7670.diff (971 bytes) - added by Ramiro Morales 8 years ago.
Trivial patch that deletes the needs_upper_for_iops database feature

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Ramiro Morales

Attachment: t7319-r7670.diff added

Trivial patch that deletes the needs_upper_for_iops database feature

comment:1 Changed 8 years ago by Ramiro Morales

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 8 years ago by Simon Greenhill

Triage Stage: UnreviewedReady for checkin

comment:3 Changed 8 years ago by Ramiro Morales

Keywords: db-be-api added

comment:4 Changed 8 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [7747]) Fixed #7319 -- Removed unused DatabaseFeatures attribute 'needs_upper_for_iops'. Thanks, leosoto

Note: See TracTickets for help on using tickets.
Back to Top