#7502 closed (fixed)
Changeset 7694 breaks I18N translation
Reported by: | Fraser Nevett | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | newforms-admin |
Severity: | Keywords: | nfa | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
It looks like part of the change made in in [7694] will inadvertently break I18N translation.
I think
message = _("Your e-mail address is not your username." " Try '%s' instead." % user.username)
should probably be
message = _("Your e-mail address is not your username." " Try '%s' instead.") % user.username
so that the string substitution is done after the translated version of the text is loaded. Otherwise there would have to be a translated version of this string for every possible username.
Attachments (1)
Change History (5)
comment:1 by , 16 years ago
Keywords: | nfa added |
---|---|
milestone: | → 1.0 alpha |
Triage Stage: | Unreviewed → Accepted |
by , 16 years ago
comment:2 by , 16 years ago
Has patch: | set |
---|---|
Version: | SVN → newforms-admin |
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
patch as per description