Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7502 closed (fixed)

Changeset 7694 breaks I18N translation

Reported by: frasern Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords: nfa
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It looks like part of the change made in in [7694] will inadvertently break I18N translation.

I think

	                        message = _("Your e-mail address is not your username." 
	                                    " Try '%s' instead." % user.username)

should probably be

	                        message = _("Your e-mail address is not your username." 
	                                    " Try '%s' instead.") % user.username

so that the string substitution is done after the translated version of the text is loaded. Otherwise there would have to be a translated version of this string for every possible username.

Attachments (1)

7502.diff (707 bytes) - added by arien 7 years ago.
patch as per description

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by telenieko

  • Keywords nfa added
  • milestone set to 1.0 alpha
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 7 years ago by arien

patch as per description

comment:2 Changed 7 years ago by arien

  • Has patch set
  • Version changed from SVN to newforms-admin

comment:3 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [7711]) newforms-admin: Fixed #7502 -- Fixed an i18n breakge introduced in [7694]. Thanks frasern.

comment:4 Changed 4 years ago by jacob

  • milestone 1.0 alpha deleted

Milestone 1.0 alpha deleted

Note: See TracTickets for help on using tickets.
Back to Top