[newforms-admin] Delete view doesn't link to related objects
|Reported by:||Daniel Roseman <daniel@…>||Owned by:||nobody|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Description (last modified by ramiro)
The get_deleted_objects function in django.contrib.admin.util lists the related objects that will be affected by a delete operation. It contains code to link each item to its actual admin page. However, this is never called because in order to check if the model has an admin page, it checks has_admin = related.__class__ in admin_site._registry - but related.__class__ is always <class 'django.db.models.related.RelatedObject'>, which naturally does not match anything in _registry. This needs to be changed to related.model, which does work.
Patch includes this change, plus big changes to the admin_views regression test and fixture to set up a related model to test this against.
Change History (4)
Changed 6 years ago by Daniel Roseman <daniel@…>
comment:1 Changed 6 years ago by ramiro
- Description modified (diff)
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset