Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#7483 closed (fixed)

[newforms-admin] Delete view doesn't link to related objects

Reported by: Daniel Roseman <daniel@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by ramiro)

The get_deleted_objects function in django.contrib.admin.util lists the related objects that will be affected by a delete operation. It contains code to link each item to its actual admin page. However, this is never called because in order to check if the model has an admin page, it checks has_admin = related.__class__ in admin_site._registry - but related.__class__ is always <class 'django.db.models.related.RelatedObject'>, which naturally does not match anything in _registry. This needs to be changed to related.model, which does work.

Patch includes this change, plus big changes to the admin_views regression test and fixture to set up a related model to test this against.

Attachments (1)

delete_related.diff (5.6 KB) - added by Daniel Roseman <daniel@…> 6 years ago.
Patch and updated tests/fixtures

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Daniel Roseman <daniel@…>

Patch and updated tests/fixtures

comment:1 Changed 6 years ago by ramiro

  • Description modified (diff)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by simon

  • Resolution set to fixed
  • Status changed from new to closed

(In [7685]) newforms-admin: Fixed #7483 (thanks, Daniel Roseman) - delete view now correctly links to related objects

comment:3 Changed 3 years ago by jacob

  • milestone 1.0 alpha deleted

Milestone 1.0 alpha deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.