Opened 7 years ago

Closed 7 years ago

#7413 closed (fixed)

Updated Hebrew translations

Reported by: mksoft Owned by: nobody
Component: Translations Version: master
Severity: Keywords: hebrew he translation
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Attached updated Hebrew (he) translations

Attachments (3)

django.po (110.3 KB) - added by mksoft 7 years ago.
7413.diff (76.5 KB) - added by Simon Greenhill 7 years ago.
A diff of mksoft's po file
django.po.diff (77.5 KB) - added by mksoft 7 years ago.
Updated patch against trunk

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by mksoft

Changed 7 years ago by Simon Greenhill

A diff of mksoft's po file

comment:1 Changed 7 years ago by Simon Greenhill

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by telenieko

On language names it reads: "somefuzzychars - original string" i.e. "xxxxxxxx - Basque" why that?
Is this a normal practice in Hebrew?

comment:3 follow-up: Changed 7 years ago by mksoft

I prefer it that way (not just for Hebrew). For example: Asumming someone lands on the site, with Hebrew as the main language. How can he/she select English, if all the languages in the select box are written in Hebrew ? Since they don't know any Hebrew, they won't be able to find the correct language (or if someone selects by accident another language and he can't spot the correct language from the translations).

comment:4 in reply to: ↑ 3 Changed 7 years ago by telenieko

If it's not a language practice I'd rather leave only the translated string (to be consistent with the rest of translations and other applications).

For what you say, the common practice is to either place the language selection link in the original form or both, i.e. (in catalan):

  • English - Anglès
  • Català - Català
  • Español - Castellà

That is, in the template: English - {% trans "English" %} would do that, then English would be in English + current language, etc.

comment:5 Changed 7 years ago by garcia_marc

  • Keywords hebrew he translation added
  • Patch needs improvement set
  • Triage Stage changed from Ready for checkin to Accepted

Actually, when creating the select box for choosing language in Django, they are used the strings in LANGUAGES directives in settings.py that can't be directly translated with gettext, so it's meaningless translating this way, that as telenieko says, can produce unexpected results in web sites.

Changed 7 years ago by mksoft

Updated patch against trunk

comment:6 Changed 7 years ago by mksoft

Thanks for the comments. Removed the English descriptions. Attached an updated patch against current trunk.

comment:7 Changed 7 years ago by telenieko

  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

Thanks mksoft.

comment:8 Changed 7 years ago by telenieko

  • Resolution set to fixed
  • Status changed from new to closed

(In [7673]) Closes #7413, Updated Hebrew translation (Thanks Meir Kriheli)

Note: See TracTickets for help on using tickets.
Back to Top