Opened 8 years ago

Closed 8 years ago

#7413 closed (fixed)

Updated Hebrew translations

Reported by: Meir Kriheli Owned by: nobody
Component: Translations Version: master
Severity: Keywords: hebrew he translation
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Attached updated Hebrew (he) translations

Attachments (3)

django.po (110.3 KB) - added by Meir Kriheli 8 years ago.
7413.diff (76.5 KB) - added by Simon Greenhill 8 years ago.
A diff of mksoft's po file
django.po.diff (77.5 KB) - added by Meir Kriheli 8 years ago.
Updated patch against trunk

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by Meir Kriheli

Attachment: django.po added

Changed 8 years ago by Simon Greenhill

Attachment: 7413.diff added

A diff of mksoft's po file

comment:1 Changed 8 years ago by Simon Greenhill

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 8 years ago by Marc Fargas

On language names it reads: "somefuzzychars - original string" i.e. "xxxxxxxx - Basque" why that?
Is this a normal practice in Hebrew?

comment:3 Changed 8 years ago by Meir Kriheli

I prefer it that way (not just for Hebrew). For example: Asumming someone lands on the site, with Hebrew as the main language. How can he/she select English, if all the languages in the select box are written in Hebrew ? Since they don't know any Hebrew, they won't be able to find the correct language (or if someone selects by accident another language and he can't spot the correct language from the translations).

comment:4 in reply to:  3 Changed 8 years ago by Marc Fargas

If it's not a language practice I'd rather leave only the translated string (to be consistent with the rest of translations and other applications).

For what you say, the common practice is to either place the language selection link in the original form or both, i.e. (in catalan):

  • English - Anglès
  • Català - Català
  • Español - Castellà

That is, in the template: English - {% trans "English" %} would do that, then English would be in English + current language, etc.

comment:5 Changed 8 years ago by Marc Garcia

Keywords: hebrew he translation added
Patch needs improvement: set
Triage Stage: Ready for checkinAccepted

Actually, when creating the select box for choosing language in Django, they are used the strings in LANGUAGES directives in settings.py that can't be directly translated with gettext, so it's meaningless translating this way, that as telenieko says, can produce unexpected results in web sites.

Changed 8 years ago by Meir Kriheli

Attachment: django.po.diff added

Updated patch against trunk

comment:6 Changed 8 years ago by Meir Kriheli

Thanks for the comments. Removed the English descriptions. Attached an updated patch against current trunk.

comment:7 Changed 8 years ago by Marc Fargas

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

Thanks mksoft.

comment:8 Changed 8 years ago by Marc Fargas

Resolution: fixed
Status: newclosed

(In [7673]) Closes #7413, Updated Hebrew translation (Thanks Meir Kriheli)

Note: See TracTickets for help on using tickets.
Back to Top