get_or_create can cause a transaction to fail silently
|Reported by:||Owned by:||nobody|
|Component:||Database layer (models, ORM)||Version:||master|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||yes|
In  a change was made to get_or_create to work around a race condition; however, the change means that if the race condition occurs then the current transaction will fail.
When an IntegrityError is raised it cannot be ignored. The transaction must be rolled back. I believe the proper action in this case is to simply let the application itself deal with the IntegrityError as it is better equipped to handle it. That is, the exception should not be caught in get_or_create.
Change History (8)
comment:1 Changed 8 years ago by
|Patch needs improvement:||unset|