Opened 7 years ago

Closed 7 years ago

#7066 closed (invalid)

global name 'authenticate' is not defined in views/comments.py

Reported by: Joaquin Quintas Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: comments
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The line from django.contrib.auth import authenticate is missing

in the file comments/views/comments.py from 'django.contrib.comments'.

Change History (6)

comment:1 follow-up: Changed 7 years ago by Alex

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

This function isn't being called anywhere in comments.py, hence it is not being imported.

comment:2 in reply to: ↑ 1 Changed 7 years ago by jquintas

  • Resolution invalid deleted
  • Status changed from closed to reopened

Replying to Alex:

This function isn't being called anywhere in comments.py, hence it is not being imported.

the function "isValidUser" is using authenticate

comment:3 Changed 7 years ago by Alex

isValidUser is not defined anywhere in that document, are you sure you are talking about django.contrib.comments.views.comments? http://code.djangoproject.com/browser/django/trunk/django/contrib/comments/views/comments.py

comment:4 follow-up: Changed 7 years ago by jquintas

I downloaded the lasted version from trunk, and it is the same file.
It is my first ticket, and I would like to contribute, maybe I am wrong sorry.

comment:5 in reply to: ↑ 4 Changed 7 years ago by jquintas

Replying to jquintas:

I downloaded the lasted version from trunk, and it is the same file.
It is my first ticket, and I would like to contribute, maybe I am wrong sorry.

I downloaded the lasted version from trunk, and it is NOT the same file. It is my first ticket, and I would like to contribute, maybe I am wrong sorry.

comment:6 Changed 7 years ago by mattmcc

  • Resolution set to invalid
  • Status changed from reopened to closed

I don't see an issue here. If you're getting an error originating in the Django code, please provide details of that.

Note: See TracTickets for help on using tickets.
Back to Top