Opened 7 years ago

Closed 7 years ago

#7033 closed (fixed)

Dead code: OrderingField

Reported by: julien Owned by: nobody
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As discussed in [1], there's a piece of code (OrderingField class in django.db.models.fields) that seems to be dead and should be considered to be removed.

[1] http://groups.google.com/group/django-users/browse_thread/thread/78669fdb8790ca3d/20fcd8384493610a#20fcd8384493610a

Attachments (1)

remove_unused_OrderField.diff (872 bytes) - added by anonymous 7 years ago.
Patch removing the dead code

Download all attachments as: .zip

Change History (3)

comment:1 Changed 7 years ago by Simon Greenhill

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

Changed 7 years ago by anonymous

Patch removing the dead code

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7794]) Fixed #7033 -- Removed an unused field.

OrderingField was added in the magic-removal branch to support something that
never ultimately materialised, but it wasn't removed. So this is
backwards-incompatible if you're using this field that has no purpose, I guess.

Note: See TracTickets for help on using tickets.
Back to Top