change django.core.handlers.base.get_response to use urlresolvers.resolve
django.core.handlers.base.get_response looks like it should use urlresolvers.resolve instead of directly instantiating urlresolvers.RegexURLResolver
Index: django/core/handlers/base.py
===================================================================
--- django/core/handlers/base.py (revision 7425)
+++ django/core/handlers/base.py (working copy)
@@ -68,9 +68,8 @@
# Get urlconf from request object, if available. Otherwise use default.
urlconf = getattr(request, "urlconf", settings.ROOT_URLCONF)
- resolver = urlresolvers.RegexURLResolver(r'^/', urlconf)
try:
- callback, callback_args, callback_kwargs = resolver.resolve(request.path)
+ callback, callback_args, callback_kwargs = urlresolvers.resolve(request.path, urlconf)
# Apply view middleware
for middleware_method in self._view_middleware:
Change History
(7)
milestone: |
→ 1.0
|
Triage Stage: |
Unreviewed → Design decision needed
|
Triage Stage: |
Design decision needed → Accepted
|
Triage Stage: |
Accepted → Design decision needed
|
Severity: |
→ Normal
|
Type: |
→ Cleanup/optimization
|
Easy pickings: |
unset
|
Resolution: |
→ needsinfo
|
Status: |
new → closed
|
UI/UX: |
unset
|
Is there actually a bug here? Because "looks like it should ..." isn't a good enough reason to change verified working code.