Opened 7 years ago

Closed 7 years ago

#7030 closed (fixed)

Allow non-ASCII characters in input for translation for multiple Javascript files

Reported by: anonymous Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

make-messages.py doesn't work well for input file containing UTF-8 strings to translate when you have multiple javascript files to translate

cd project_dir
copy test.js to template directory
# run make_messages
# python /opt/django-0.97_pre7403/django/bin/make-messages.py -a -d djangojs
processing language fr

everything is fine

Problem occures when you have multiple JS file to translate:

copy test2.js to template directory
# run make_messages
# python /opt/django-0.97_pre7403/django/bin/make-messages.py -a -d djangojs
processing language fr
errors happened while running xgettext on test2.js
pl:2: warning: The following msgid contains non-ASCII characters.
               This will cause problems to translators who use a character encoding
               different from yours. Consider using a pure ASCII msgid instead.
               déjeuner
pl:2: invalid multibyte sequence
pl:2: invalid multibyte sequence
pl:2: invalid multibyte sequence
pl:2: invalid multibyte sequence

with patched version :

# python /opt/django-0.97_pre7403/django/bin/make-messages.py.patched -a -d djangojs
processing language fr 

Attachments (3)

test.js (53 bytes) - added by anonymous 7 years ago.
Javascript file #1 for testing purpose
test2.js (52 bytes) - added by anonymous 7 years ago.
Javascript file #2 for testing purpose
make-message.patch (1.7 KB) - added by anonymous 7 years ago.
make-messages.py patch to deal with JS files as .html files (no use of omit-header) and stripping header if .pot file exists

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by anonymous

Javascript file #1 for testing purpose

Changed 7 years ago by anonymous

Javascript file #2 for testing purpose

Changed 7 years ago by anonymous

make-messages.py patch to deal with JS files as .html files (no use of omit-header) and stripping header if .pot file exists

comment:1 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [7473]) Fixed #7030 -- Handle extraction of UTF-8 messages from Javascript files.

This leads to more duplicated code in make-messages.py, but this is just a
holdover for the immediate problem until we merge make-messages into
management/.

Note: See TracTickets for help on using tickets.
Back to Top