Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7011 closed (fixed)

Authentication documentation doesn't describe is_active very well.

Reported by: mtredinnick Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The documentation for the User class in the authentication docs doesn't describe the effect of the is_active flag. It could easily lead people to suspect that the flag enforces whether the person can log in, however it is just a flag and the user's code needs to check it when determining whether to grant the user access to things. Nothing in the User model or login path enforces is_active (which is a good thing), although permission checking does respect it (useful for things doing model-level permission checking).

I'm not going to fix this now, since the documentation directory is undergoing churn at the moment whilst Jacob refactors it. This should wait until after that is finished.

Attachments (0)

Change History (5)

comment:1 Changed 6 years ago by mtredinnick

(In [7414]) Updated the inline help text for User.is_active.

Fixed #6881. Refs #7011.

comment:2 Changed 6 years ago by Simon Greenhill

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 6 years ago by telenieko

  • Has patch unset
  • Triage Stage changed from Ready for checkin to Accepted

Why Ready for checkin? There's no patch attached and even malcolm said he's not going to fix this now.

comment:4 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [9176]) Fixed #7011 -- Clarified what User.is_active really means in the documentation.

comment:5 Changed 6 years ago by mtredinnick

(In [9179]) [1.0.X] Fixed #7011 -- Clarified what User.is_active really means in the documentation.

Backport of r9176 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.