Code

Opened 6 years ago

Closed 2 years ago

#6916 closed Uncategorized (fixed)

Es Localflavour has wrong province

Reported by: telenieko Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I never had good scores at Spanish but I'm almost sure Arava is not a spanish province, Maybe it's ALAVA?
Attaching patch.

Attachments (1)

alava.diff (471 bytes) - added by telenieko 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by telenieko

comment:1 Changed 6 years ago by telenieko

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by garcia_marc

  • Resolution set to invalid
  • Status changed from new to closed

Province names in code are in english. When no english name exists for the province, the local name is used.

In this case doesn't exists a specific english name, so basque name is used for basque province 'Arava'. You can find spanish name 'Álava' on spanish translation.

Closing ticket as invalid.

comment:3 follow-up: Changed 2 years ago by gserra

  • Easy pickings unset
  • Resolution invalid deleted
  • Severity set to Normal
  • Status changed from closed to reopened
  • Type set to Uncategorized
  • UI/UX unset

I would recommed to check it again. The correct local name should be "araba" and not "arava".

http://en.wikipedia.org/wiki/Provinces_of_Spain

comment:4 in reply to: ↑ 3 Changed 2 years ago by ramiro

  • Resolution set to invalid
  • Status changed from reopened to closed

Replying to gserra:

I would recommed to check it again. The correct local name should be "araba" and not "arava".

http://en.wikipedia.org/wiki/Provinces_of_Spain

I don't see there any information that adds anything new information to this ticket, especially taking in account comment:2 so I still don't see any reason to change its status.

Please reopen only if you can explain more verbosely what has changed how it does affect the policy the translator is using.

comment:5 Changed 2 years ago by anonymous

  • Resolution invalid deleted
  • Status changed from closed to reopened

The province name in English is "araba" and not "arava". In Django is written as "arava" and it is wrong.

I am not saying that it should be "álava" but that the correct english name is not "arava" but "araba". As you can see here http://en.wikipedia.org/wiki/Provinces_of_Spain

comment:6 Changed 2 years ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from reopened to closed

In [4774875896dec4098dba2981d562bd74e75c463f]:

Fixed #6916 -- Wrong spelling of Spanish province.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.