Opened 7 years ago

Closed 7 years ago

#6779 closed (fixed)

Don't show delete checkbox for "extra" inline items

Reported by: SmileyChris Owned by: brosner
Component: contrib.admin Version: newforms-admin
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Easy fix, here's the patch.

Attachments (1)

inline_delete_only_existing.diff (2.6 KB) - added by SmileyChris 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by SmileyChris

comment:1 Changed 7 years ago by brosner

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to brosner
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by brosner

  • Triage Stage changed from Ready for checkin to Accepted

New hooks provide more places to do this nicely.

comment:3 Changed 7 years ago by SmileyChris

Doh, I actually did that initially (at the formset level). I thought you'd prefer the more sedated version ;)

comment:4 Changed 7 years ago by brosner

Okay, actually thought about this and your patch is the most correct way. Will apply shortly.

comment:5 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7367]) newforms-admin: Fixed #6779 -- Removed the delete checkbox for "extra" inlines. Thanks, SmileyChris.

Note: See TracTickets for help on using tickets.
Back to Top